Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxslt: make generate-id deterministic #97135

Closed
wants to merge 1 commit into from

Conversation

@xfix
Copy link
Contributor

@xfix xfix commented Sep 4, 2020

Motivation for this change

This makes NixOS manual builds reproducible. This patch was included in Debian for 3 years, so it probably should work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This makes NixOS manual builds reproducible.
@xfix xfix force-pushed the xfix:libxslt-deterministc-generate-id branch from 7d259e6 to 2a3d31b Sep 4, 2020
@xfix xfix changed the base branch from master to staging Sep 4, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM (including patch contents)

@xfix
Copy link
Contributor Author

@xfix xfix commented Sep 4, 2020

Actually, I think I will close that one because apparently Debian patch has bugs :(

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902051

I think should be dealt with (at least for NixOS manual) by NixOS/rfcs#72. This bug also affects wayland on r13y.com from what I can tell as it's also using Docbook.

@xfix xfix closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.