Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.diagnostic-languageserver: init at 1.7.1 #97149

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@felschr
Copy link
Contributor

felschr commented Sep 4, 2020

Motivation for this change

Add diagnostic-languageserver, a general purpose language server that integrates with linters.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@felschr
Copy link
Contributor Author

felschr commented Sep 4, 2020

I just ran nixpkgs-review on my changes and joplin fails to build but apparently it already failed before.

@felschr felschr force-pushed the felschr:feat/diagnostic-languageserver branch from eac8133 to c8ccaeb Sep 14, 2020
@ofborg ofborg bot requested a review from midchildan Sep 14, 2020
@nixos-discourse
Copy link

nixos-discourse commented Sep 16, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/227

@AndersonTorres AndersonTorres merged commit ec5e9b6 into NixOS:master Sep 16, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c8ccaeb"; rev="c8ccaebfe4b67d819d225e8016d9f3d2b543a906"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c8ccaeb"; rev="c8ccaebfe4b67d819d225e8016d9f3d2b543a906"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c8ccaeb"; rev="c8ccaebfe4b67d819d225e8016d9f3d2b543a906"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c8ccaeb"; rev="c8ccaebfe4b67d819d225e8016d9f3d2b543a906"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c8ccaeb"; rev="c8ccaebfe4b67d819d225e8016d9f3d2b543a906"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c8ccaeb"; rev="c8ccaebfe4b67d819d225e8016d9f3d2b543a906"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c8ccaeb"; rev="c8ccaebfe4b67d819d225e8016d9f3d2b543a906"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.