Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginkgo: 1.14.0 -> 1.14.1 #97150

Merged
merged 1 commit into from Sep 4, 2020
Merged

ginkgo: 1.14.0 -> 1.14.1 #97150

merged 1 commit into from Sep 4, 2020

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 4, 2020

Motivation for this change

Update to the latest rlease
cc @zowoq

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

@saschagrunert saschagrunert commented Sep 4, 2020

@GrahamcOfBorg build ginkgo

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 97150 1

1 package built:
  • ginkgo

@jonringer jonringer merged commit f55650b into NixOS:master Sep 4, 2020
5 checks passed
5 checks passed
tests tests
Details
action
Details
Wait for ofborg
Details
ginkgo on aarch64-linux Success
Details
ginkgo on x86_64-linux Success
Details
@saschagrunert saschagrunert deleted the saschagrunert:ginkgo branch Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.