Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home assistant plugins: pysqueezebox and yeelight #97151

Merged
merged 2 commits into from Sep 6, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 4, 2020

Motivation for this change

closes #96689

used this a template to make a video on how to use git rebase -i to cleanup your git history

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
nyanloutre added 2 commits Aug 30, 2020
@jonringer jonringer requested a review from FRidh as a code owner Sep 4, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Sep 4, 2020

@ofborg ofborg bot added the 6.topic: python label Sep 4, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 6, 2020

LGTM.

Result of nixpkgs-review pr 97151 1

5 packages built:
- python27Packages.yeelight
- python37Packages.pysqueezebox
- python37Packages.yeelight
- python38Packages.pysqueezebox
- python38Packages.yeelight
@mweinelt mweinelt merged commit bf72d1b into NixOS:master Sep 6, 2020
10 of 13 checks passed
10 of 13 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval Complete, with errors
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca7b509"; rev="ca7b509dff37f6051357a45d2b50771d56308121"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca7b509"; rev="ca7b509dff37f6051357a45d2b50771d56308121"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca7b509"; rev="ca7b509dff37f6051357a45d2b50771d56308121"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca7b509"; rev="ca7b509dff37f6051357a45d2b50771d56308121"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca7b509"; rev="ca7b509dff37f6051357a45d2b50771d56308121"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ca7b509"; rev="ca7b509dff37f6051357a45d2b50771d56308121"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:home_assistant_plugins branch Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.