Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fontparts: 0.9.2 → 0.9.6 #97211

Merged
merged 1 commit into from Sep 7, 2020

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 5, 2020

Motivation for this change

https://github.com/robotools/fontParts/releases/tag/v0.9.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sternenseemann sternenseemann requested review from FRidh and jonringer as code owners Sep 5, 2020
@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 5, 2020

@GrahamcOfBorg build python3Packages.nototools

@ofborg ofborg bot added the 6.topic: python label Sep 5, 2020
Copy link
Contributor

@drewrisinger drewrisinger left a comment

https://github.com/NixOS/nixpkgs/pull/97211
10 packages built:
noto-fonts-emoji python37Packages.afdko python37Packages.fontparts python37Packages.nototools python37Packages.ufoprocessor python38Packages.afdko python38Packages.fontparts python38Packages.nototools python38Packages.ufoprocessor twitter-color-emoji
@seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Sep 5, 2020

Executed nix build .#python3Packages.fontparts with flake support enabled on this PR and the package built just fine.

@sternenseemann sternenseemann force-pushed the sternenseemann:fontparts-0.9.5 branch from ce18ca7 to 68d9107 Sep 6, 2020
@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 6, 2020

@sternenseemann sternenseemann force-pushed the sternenseemann:fontparts-0.9.5 branch from 68d9107 to 75e7360 Sep 7, 2020
@sternenseemann sternenseemann changed the title pythonPackages.fontparts: 0.9.2 → 0.9.5 pythonPackages.fontparts: 0.9.2 → 0.9.6 Sep 7, 2020
@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 7, 2020

@GrahamcOfBorg build python3Packages.nototools

Copy link
Contributor

@jonringer jonringer left a comment

EDIT: this was meant for a different PR

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 97211 1

10 packages built:
  • noto-fonts-emoji
  • python37Packages.afdko
  • python37Packages.fontparts
  • python37Packages.nototools
  • python37Packages.ufoprocessor
  • python38Packages.afdko
  • python38Packages.fontparts
  • python38Packages.nototools
  • python38Packages.ufoprocessor
  • twitter-color-emoji

@jonringer jonringer merged commit 227b210 into NixOS:master Sep 7, 2020
21 checks passed
21 checks passed
tests tests
Details
action
Details
nototools on aarch64-linux No attempt
Details
nototools on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e7360"; rev="75e736015a192b63de53500d7a97ad13a8c6e6bb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e7360"; rev="75e736015a192b63de53500d7a97ad13a8c6e6bb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e7360"; rev="75e736015a192b63de53500d7a97ad13a8c6e6bb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e7360"; rev="75e736015a192b63de53500d7a97ad13a8c6e6bb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e7360"; rev="75e736015a192b63de53500d7a97ad13a8c6e6bb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e7360"; rev="75e736015a192b63de53500d7a97ad13a8c6e6bb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e7360"; rev="75e736015a192b63de53500d7a97ad13a8c6e6bb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.nototools on aarch64-linux Success
Details
python3Packages.nototools on x86_64-linux Success
Details
@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 7, 2020

please add openssl to the inputs.

I don't understand. fontparts doesn't import openssl at all?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 7, 2020

I'm trying to do reviews on my laptop, meant it for another PR

Edit: specifically, this was meant for #97349

@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 7, 2020

No problem, just was confused :)

@sternenseemann sternenseemann deleted the sternenseemann:fontparts-0.9.5 branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.