Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxsmm: 1.15 -> 1.16.1, improve derivation #97227

Merged
merged 1 commit into from Sep 16, 2020
Merged

Conversation

@danieldk
Copy link
Member

danieldk commented Sep 5, 2020

Motivation for this change

The following changes are made to the derivation besides the version
bump:

  • Move all buildInputs to nativeBuildInputs.
  • Switch from Python 2 to Python 3.
  • Build a dynamic library by default.
  • Use gfortran version corresponding to gcc version.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danieldk danieldk changed the title libxsmm: 1.15 -> 1.16.1, improve derivations libxsmm: 1.15 -> 1.16.1, improve derivation Sep 5, 2020
@danieldk danieldk force-pushed the danieldk:libxsmm-1.16.1 branch from 50647a1 to 4b95ad3 Sep 5, 2020
@danieldk danieldk force-pushed the danieldk:libxsmm-1.16.1 branch from 4b95ad3 to 5d1e665 Sep 13, 2020
@danieldk danieldk requested a review from chessai Sep 13, 2020
The following changes are made to the derivation besides the version
bump:

- Move all buildInputs to nativeBuildInputs.
- Switch from Python 2 to Python 3.
- Build a dynamic library by default.
- Use gfortran version corresponding to gcc version.
- Enable parallel building.
@danieldk danieldk force-pushed the danieldk:libxsmm-1.16.1 branch from 5d1e665 to 9be28ee Sep 13, 2020
@chessai
Copy link
Member

chessai commented Sep 16, 2020

LGTM

@danieldk danieldk merged commit 6338098 into NixOS:master Sep 16, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
libxsmm, libxsmm.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9be28ee"; rev="9be28ee3615d8c26e01b29103390a25634b0845e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9be28ee"; rev="9be28ee3615d8c26e01b29103390a25634b0845e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9be28ee"; rev="9be28ee3615d8c26e01b29103390a25634b0845e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9be28ee"; rev="9be28ee3615d8c26e01b29103390a25634b0845e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9be28ee"; rev="9be28ee3615d8c26e01b29103390a25634b0845e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9be28ee"; rev="9be28ee3615d8c26e01b29103390a25634b0845e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9be28ee"; rev="9be28ee3615d8c26e01b29103390a25634b0845e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libxsmm, libxsmm.passthru.tests on x86_64-linux Success
Details
@danieldk danieldk deleted the danieldk:libxsmm-1.16.1 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.