Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd-local: init at 1.0.5 #97237

Merged
merged 1 commit into from Oct 2, 2020
Merged

sd-local: init at 1.0.5 #97237

merged 1 commit into from Oct 2, 2020

Conversation

@midchildan
Copy link
Contributor

@midchildan midchildan commented Sep 5, 2020

Motivation for this change

sd-local is a command line tool to run screwdriver.cd CI jobs on local development machines.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@midchildan
Copy link
Contributor Author

@midchildan midchildan commented Sep 5, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Sep 5, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@timokau
Copy link
Member

@timokau timokau commented Oct 1, 2020

15 watchers on GitHub, yet no stars. Seems weird 😕

Anyway, pending ofBorgs approval this looks good to me. Not sure why it doesn't run automatically. Please ping me once it has succeeded.

@GrahamcOfBorg build sd-local

@timokau
timokau approved these changes Oct 1, 2020
@timokau
Copy link
Member

@timokau timokau commented Oct 1, 2020

@midchildan
Copy link
Contributor Author

@midchildan midchildan commented Oct 2, 2020

I'd imagine most people interested in screwdriver.cd would star the main screwdriver repository instead. Anyways, thanks for reviewing!

@timokau timokau merged commit d832ca8 into NixOS:master Oct 2, 2020
20 of 22 checks passed
20 of 22 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
sd-local on x86_64-darwin
Details
sd-local on aarch64-linux No attempt
Details
sd-local, sd-local.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5219f8e"; rev="5219f8e76b0469bf825652f14c2b665e216257e1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5219f8e"; rev="5219f8e76b0469bf825652f14c2b665e216257e1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5219f8e"; rev="5219f8e76b0469bf825652f14c2b665e216257e1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5219f8e"; rev="5219f8e76b0469bf825652f14c2b665e216257e1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5219f8e"; rev="5219f8e76b0469bf825652f14c2b665e216257e1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5219f8e"; rev="5219f8e76b0469bf825652f14c2b665e216257e1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5219f8e"; rev="5219f8e76b0469bf825652f14c2b665e216257e1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sd-local on x86_64-linux Success
Details
sd-local, sd-local.passthru.tests on x86_64-linux Success
Details
@midchildan midchildan deleted the midchildan:package/sd-local branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.