Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparkleshare: Add git-lfs dependency. #97239

Merged
merged 1 commit into from Sep 7, 2020
Merged

Conversation

@kevincox
Copy link
Contributor

@kevincox kevincox commented Sep 5, 2020

SparkleShare failed to sync some repos because it failed to find the git-lfs command.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kevincox kevincox self-assigned this Sep 5, 2020
@seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Sep 5, 2020

I executed nix-review pr 97239 and it executed successfully. Inside the sandbox I ran sparkeshare --help and it worked just fine.

@kevincox
Copy link
Contributor Author

@kevincox kevincox commented Sep 5, 2020

Yeah, the error reported seems to be unrelated but I'll take a look (or just try rebasing) when I get a chance. It might be a dependency of git-lfs that is already broken?

I can confirm that I am running this build on my NixOS desktop and it is working.

SparkleShare failed to sync some repos because it failed to find the git-lfs command.
@kevincox kevincox force-pushed the kevincox-sparkleshare-lfs branch from 33516f9 to c626890 Sep 7, 2020
@kevincox kevincox merged commit 13d483a into master Sep 7, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c626890"; rev="c6268906e7e1cdd5c98526db41255c9f6e7af5d2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c626890"; rev="c6268906e7e1cdd5c98526db41255c9f6e7af5d2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c626890"; rev="c6268906e7e1cdd5c98526db41255c9f6e7af5d2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c626890"; rev="c6268906e7e1cdd5c98526db41255c9f6e7af5d2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c626890"; rev="c6268906e7e1cdd5c98526db41255c9f6e7af5d2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c626890"; rev="c6268906e7e1cdd5c98526db41255c9f6e7af5d2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c626890"; rev="c6268906e7e1cdd5c98526db41255c9f6e7af5d2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sparkleshare, sparkleshare.passthru.tests on aarch64-linux Success
Details
sparkleshare, sparkleshare.passthru.tests on x86_64-linux Success
Details
@kevincox kevincox deleted the kevincox-sparkleshare-lfs branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.