Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cinnamon: init #97256

Merged
merged 25 commits into from Sep 7, 2020
Merged

nixos/cinnamon: init #97256

merged 25 commits into from Sep 7, 2020

Conversation

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Sep 5, 2020

Motivation for this change

Make it happen ™️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 07707e5 to 115772f Sep 5, 2020
@ofborg ofborg bot requested a review from romildo Sep 5, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 0e3560a to 5385051 Sep 5, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch 2 times, most recently from 495ae74 to 526ceef Sep 5, 2020
@ofborg ofborg bot added the 6.topic: cinnamon label Sep 5, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 1ef8410 to 61462d4 Sep 5, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 61462d4 to aa0a481 Sep 6, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch 2 times, most recently from e3fe2b2 to dc0c457 Sep 6, 2020
@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Sep 6, 2020

image
image

@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 09b0c7e to 65ad9de Sep 7, 2020
mkg20001 added 4 commits Sep 6, 2020
The package debian/copyright states Attribution-ShareAlike 3.0 Unported 
(CC BY-SA 3.0) which is cc-by-sa-30, was wrongly cc-by-nc-sa-30 which is 
unfree
@worldofpeace worldofpeace changed the title modules.cinnamon: add cinnamon module nixos/cinnamon: init Sep 7, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch 3 times, most recently from ca1bdc5 to 6ba142e Sep 7, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 6ba142e to aa20a22 Sep 7, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Sep 7, 2020

There's a path to the onboard theme in the mint-artwork override that isn't patched right
theme='/nix/store/bxv49xfvc0m5kxbrd03bsl4hj5xr0j5p-mint-artwork-1.4.3/share/mint-artwork/onboard/Nightshade.theme'
that belongs to onboard

@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch 2 times, most recently from 5acf2f9 to 6d2c15f Sep 7, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Sep 7, 2020

There's a path to the onboard theme in the mint-artwork override that isn't patched right
theme='/nix/store/bxv49xfvc0m5kxbrd03bsl4hj5xr0j5p-mint-artwork-1.4.3/share/mint-artwork/onboard/Nightshade.theme'
that belongs to onboard

Turns out this does exist. It seems they changed the Nightshade theme from onboard in an almost imperceptible way. I guess too little for us to care about.

@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 6d2c15f to 645a97e Sep 7, 2020
Co-Authored-By: WORLDofPEACE <worldofpeace@protonmail.ch>
@mkg20001 mkg20001 force-pushed the mkg20001:cinnamon-module branch from 645a97e to 04ea3a0 Sep 7, 2020
@ofborg ofborg bot requested a review from romildo Sep 7, 2020
@worldofpeace worldofpeace merged commit fcc395d into NixOS:master Sep 7, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.