Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport hovercraft fix #97333

Merged

Conversation

@makefu
Copy link
Contributor

@makefu makefu commented Sep 7, 2020

Motivation for this change

Backport #82641 , unbreaks package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

xfix and others added 2 commits Mar 15, 2020
(cherry picked from commit 46d3cf2)
@makefu makefu requested a review from Mic92 Sep 7, 2020
@makefu makefu changed the base branch from nixos-20.03 to release-20.03 Sep 7, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 7, 2020

Builds and runs up to usage. Thanks!

Result of nixpkgs-review pr 97333 1

1 package built:
  • hovercraft
@mweinelt mweinelt merged commit 4bd1938 into NixOS:release-20.03 Sep 7, 2020
17 of 18 checks passed
17 of 18 checks passed
hovercraft, hovercraft.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f59f618"; rev="f59f61817cf1ea7c2b5acb416d6e769d09977278"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f59f618"; rev="f59f61817cf1ea7c2b5acb416d6e769d09977278"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f59f618"; rev="f59f61817cf1ea7c2b5acb416d6e769d09977278"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f59f618"; rev="f59f61817cf1ea7c2b5acb416d6e769d09977278"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f59f618"; rev="f59f61817cf1ea7c2b5acb416d6e769d09977278"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f59f618"; rev="f59f61817cf1ea7c2b5acb416d6e769d09977278"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f59f618"; rev="f59f61817cf1ea7c2b5acb416d6e769d09977278"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
hovercraft, hovercraft.passthru.tests on aarch64-linux Success
Details
hovercraft, hovercraft.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.