Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptade pytest-timeout and x265 derivations #97344

Open
wants to merge 3 commits into
base: master
from

Conversation

@jpgu-epam
Copy link

@jpgu-epam jpgu-epam commented Sep 7, 2020

Motivation for this change

Update the following derivations and remove old patches on those:

  • pytest-timeout: 1.3.3 -> 1.4.2
  • x265: 3.2 -> 3.4
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jpgu-epam jpgu-epam requested review from FRidh and jonringer as code owners Sep 7, 2020
@jpgu-epam jpgu-epam changed the title Nixos 20.03 patches Uptade pytest-timeout and x265 derivations Sep 7, 2020
@ofborg ofborg bot added the 6.topic: python label Sep 7, 2020
@ofborg ofborg bot requested review from costrouc, makefu and codyopel Sep 7, 2020
Copy link
Contributor

@jonringer jonringer left a comment

I notice that your branch name mentions nixos-20.03. Unless it's a security update, this likely won't get backported (due to potential breakages)

pkgs/development/libraries/x265/default.nix Outdated Show resolved Hide resolved
@jpgu-epam
Copy link
Author

@jpgu-epam jpgu-epam commented Sep 9, 2020

I notice that your branch name mentions nixos-20.03. Unless it's a security update, this likely won't get backported (due to potential breakages)

So, should I create a PR to nixpkgs-20.03 as well?

@jpgu-epam jpgu-epam mentioned this pull request Sep 10, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.