Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcpp: add patch for CVE-2019-14274 #97345

Merged
merged 1 commit into from Sep 22, 2020

Conversation

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Sep 7, 2020

Fixes #67197

Motivation for this change

Patch CVE-2019-14274. In fact, I'd prefer to see mcpp removed altogether. If anyone feels inclined to do that, please step up. :-) See #68571 for discussion on how to remove mcpp (Xorg dependency).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ckauhaus ckauhaus requested a review from volth Sep 7, 2020
@ckauhaus ckauhaus changed the title mccp: add patch for CVE-2019-14274 mcpp: add patch for CVE-2019-14274 Sep 7, 2020
pkgs/development/compilers/mcpp/default.nix Outdated Show resolved Hide resolved
Fixes #67197
@ckauhaus ckauhaus force-pushed the ckauhaus:67197-mcpp-cve-2019-14274 branch from 587c058 to c60cafa Sep 10, 2020
@ckauhaus
Copy link
Contributor Author

@ckauhaus ckauhaus commented Sep 10, 2020

@conferno better?

@ckauhaus ckauhaus merged commit 44a70c9 into NixOS:master Sep 22, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c60cafa"; rev="c60cafa719ba22772114f4c35df14fb18f66a66f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c60cafa"; rev="c60cafa719ba22772114f4c35df14fb18f66a66f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c60cafa"; rev="c60cafa719ba22772114f4c35df14fb18f66a66f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c60cafa"; rev="c60cafa719ba22772114f4c35df14fb18f66a66f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c60cafa"; rev="c60cafa719ba22772114f4c35df14fb18f66a66f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c60cafa"; rev="c60cafa719ba22772114f4c35df14fb18f66a66f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c60cafa"; rev="c60cafa719ba22772114f4c35df14fb18f66a66f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ckauhaus ckauhaus deleted the ckauhaus:67197-mcpp-cve-2019-14274 branch Sep 22, 2020
@Izorkin Izorkin mentioned this pull request Sep 23, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.