Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/netdata: add config option for disabling analytics #97361

Open
wants to merge 1 commit into
base: master
from

Conversation

@DeeUnderscore
Copy link
Contributor

@DeeUnderscore DeeUnderscore commented Sep 7, 2020

Add services.netdata.enableAnalyticsReporting (default true), an option that sets a DO_NOT_TRACK environment variable to inform Netdata that it should not send usage statistics.

Motivation for this change

Netdata sends usage statistics to Google Analytics by default. There is an opt out mechanism that requires either placing a file called .opt-out-from-anonymous-statistics in Netdata's config directory, or setting the DO_NOT_TRACK environment variable; the latter seemed like the easier solution.

There is no way to opt out via the config file, so this necessitates a new option. The option defaults to true for consistency with upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I checked if the systemd unit is configured with the environment variable properly, but did not try to verify whether or not Netdata actually sends or doesn't send analytics according to it.

Option disables analytics through the DO_NOT_TRACK environment variable,
as detailed in
https://learn.netdata.cloud/docs/agent/anonymous-statistics

Netdata defaults to analytics on, so the option does as well.
@DeeUnderscore DeeUnderscore force-pushed the DeeUnderscore:netdata-analytics-optout branch from 0a5e53a to 5c287e6 Sep 7, 2020
@DeeUnderscore DeeUnderscore changed the title netdata: add config option for disabling analytics nixos/netdata: add config option for disabling analytics Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.