Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bitwarden_rs: add environmentFile option #97371

Merged
merged 1 commit into from Sep 8, 2020

Conversation

@WilliButz
Copy link
Member

@WilliButz WilliButz commented Sep 7, 2020

Motivation for this change

Bitwarden_rs is configured using a systemd environment file, which is locally generated in the module. To pass secrets to the service, one could either use the config option or set services.systemd.bitwarden_rs.environment.
Both of these approaches would lead to having secrets in the world-readable Nix store.

As discussed on IRC, there are a few ways to work around this issue. The ideal solution (as outlined by @ju1m) would probably be to allow the merging of single values and lists of the same type to a single list of definitions (for some of the options available in unit files, such as EnvironmentFile and ExecStartPre).

But even without the improved option merging, exposing an option environmentFile, very much like the one in the alertmanager module, would make passing secrets easier. The alternative would be to expect users to set systemd.services.bitwarden_rs.serviceConfig.EnvironmentFile themselves.

Things done

Added the option environmentFile to allow passing secrets to the service
without adding them to the Nix store, while keeping the current
configuration via the existing environment file intact.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Add the option `environmentFile` to allow passing secrets to the service
without adding them to the Nix store, while keeping the current
configuration via the existing environment file intact.
@Ma27
Ma27 approved these changes Sep 8, 2020
@Ma27 Ma27 merged commit 40f7a4e into NixOS:master Sep 8, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76362dd"; rev="76362dd7eb2622f7809961b400f357f360de537f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76362dd"; rev="76362dd7eb2622f7809961b400f357f360de537f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76362dd"; rev="76362dd7eb2622f7809961b400f357f360de537f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76362dd"; rev="76362dd7eb2622f7809961b400f357f360de537f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76362dd"; rev="76362dd7eb2622f7809961b400f357f360de537f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76362dd"; rev="76362dd7eb2622f7809961b400f357f360de537f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76362dd"; rev="76362dd7eb2622f7809961b400f357f360de537f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ju1m ju1m mentioned this pull request Sep 18, 2020
1 of 11 tasks complete
@WilliButz WilliButz deleted the WilliButz:bitwarden_rs/environment-file branch Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.