Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.gitui: 0.9.1 -> 0.10.1 #97374

Merged
merged 1 commit into from Oct 15, 2020
Merged

gitAndTools.gitui: 0.9.1 -> 0.10.1 #97374

merged 1 commit into from Oct 15, 2020

Conversation

@yanganto
Copy link
Contributor

@yanganto yanganto commented Sep 7, 2020

Motivation for this change

Update gitui to 0.10.1
This PR need to be merged after Rust 1.46 merged

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    No diff detected, stopping review...
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@yanganto
Copy link
Contributor Author

@yanganto yanganto commented Oct 12, 2020

@filatex77 This package is updated and ready with Rust 1.46. May you review on this? Many thanks.

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 13, 2020

@yanganto Why is this targeting staging?

@yanganto
Copy link
Contributor Author

@yanganto yanganto commented Oct 13, 2020

@ryantm Because Rust 1_46 is required for building this version of gitui.
Should I wait the Rust 1_46 ready in master then PR on the master?
Thanks for review.

@yanganto yanganto force-pushed the yanganto:gitui-10.1 branch from 1dccf46 to d9b4667 Oct 15, 2020
@yanganto yanganto requested a review from edolstra as a code owner Oct 15, 2020
@yanganto yanganto changed the base branch from staging to master Oct 15, 2020
@yanganto yanganto force-pushed the yanganto:gitui-10.1 branch from d9b4667 to 10fa8b6 Oct 15, 2020
- add python3 for nativeBuildInputs
- add xorg.libxcb for buildInputs

Co-authored-by: Jon <jonringer@users.noreply.github.com>
@yanganto
Copy link
Contributor Author

@yanganto yanganto commented Oct 15, 2020

@ryantm the PR target is changed to master, and the Rust 1_46 is ready in master. ^ _ ^

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 15, 2020

Result of nixpkgs-review pr 97374 1

1 package built:
- gitAndTools.gitui
@ryantm
Copy link
Member

@ryantm ryantm commented Oct 15, 2020

@yanganto So much faster to review now that Hydra has built rust!

@ryantm ryantm merged commit c39f08a into NixOS:master Oct 15, 2020
17 checks passed
17 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="866ce94"; rev="866ce944021d37335a819c85a6eeab4900e4f1b2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="866ce94"; rev="866ce944021d37335a819c85a6eeab4900e4f1b2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="866ce94"; rev="866ce944021d37335a819c85a6eeab4900e4f1b2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="866ce94"; rev="866ce944021d37335a819c85a6eeab4900e4f1b2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="866ce94"; rev="866ce944021d37335a819c85a6eeab4900e4f1b2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="866ce94"; rev="866ce944021d37335a819c85a6eeab4900e4f1b2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="866ce94"; rev="866ce944021d37335a819c85a6eeab4900e4f1b2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.