Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/xmonad: give users some build and runtime control #97381

Merged
merged 2 commits into from Sep 8, 2020

Conversation

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Sep 7, 2020

Motivation for this change

Make the xmonad module more configurable. Give users some build and runtime control.
Concretely this will add two options:

  • xmonadCliArgs for passing command line arguments to the final xmonad binary
  • ghcArgs for passing command line arguments to the ghc invocation when compiling
@xaverdh xaverdh changed the title WIP: nixos/xmonad: allow passing command line arguments WIP: nixos/xmonad: give users some build and runtime control Sep 7, 2020
@xaverdh
Copy link
Contributor Author

@xaverdh xaverdh commented Sep 7, 2020

Would also like to pass build time parameters to ghc, that requires #97380 though

@xaverdh xaverdh changed the title WIP: nixos/xmonad: give users some build and runtime control nixos/xmonad: give users some build and runtime control Sep 8, 2020
@Lassulus Lassulus merged commit dd96606 into NixOS:master Sep 8, 2020
2 of 4 checks passed
2 of 4 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.