Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/picom: add experimentalBackends option #97390

Merged
merged 1 commit into from Sep 26, 2020

Conversation

@axelf4
Copy link
Contributor

@axelf4 axelf4 commented Sep 7, 2020

Motivation for this change

This option is only available as a command-line flag and not from the config file, that is services.picom.settings. Therefore it is more important that it gets its own option.

One reason one might need this set is that blur methods other than kernel do not work with the old backends, see yshui/picom#464.

For reference, the home-manager picom module exposes this option too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This option is only available as a command-line flag and not from the
config file, that is `services.picom.settings`. Therefore it is more
important that it gets its own option.

One reason one might need this set is that blur methods other than
kernel do not work with the old backends, see yshui/picom#464.

For reference, the home-manager picom module exposes this option too.
@axelf4 axelf4 force-pushed the axelf4:picom-experimentalBackends-option branch from db10e5b to b6139e5 Sep 9, 2020
@axelf4 axelf4 requested a review from aanderse Sep 9, 2020
@aanderse aanderse requested a review from Enzime Sep 9, 2020
Copy link
Contributor

@aanderse aanderse left a comment

Simple enough change, LGTM 👍

I've never used picom and have no specific knowledge of it, so it would be nice to get an approval from one of the maintainers before merge... ping @Twey @Enzime @ertes

If we don't hear back in a few days feel free to ping me and we'll merge. Thanks!

@axelf4
Copy link
Contributor Author

@axelf4 axelf4 commented Sep 24, 2020

@aanderse It does not look like the maintainers are available.

@aanderse
Copy link
Contributor

@aanderse aanderse commented Sep 26, 2020

@axelf4 thanks for the PR and ping 🎉

@aanderse aanderse merged commit 1032e90 into NixOS:master Sep 26, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6139e5"; rev="b6139e58e3ae82a7574b1e99b0601f50d01a2aa1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6139e5"; rev="b6139e58e3ae82a7574b1e99b0601f50d01a2aa1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6139e5"; rev="b6139e58e3ae82a7574b1e99b0601f50d01a2aa1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6139e5"; rev="b6139e58e3ae82a7574b1e99b0601f50d01a2aa1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6139e5"; rev="b6139e58e3ae82a7574b1e99b0601f50d01a2aa1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6139e5"; rev="b6139e58e3ae82a7574b1e99b0601f50d01a2aa1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6139e5"; rev="b6139e58e3ae82a7574b1e99b0601f50d01a2aa1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.