Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma5: 5.18.5 -> 5.19.5 #97391

Open
wants to merge 1 commit into
base: master
from
Open

plasma5: 5.18.5 -> 5.19.5 #97391

wants to merge 1 commit into from

Conversation

@Thra11
Copy link
Contributor

@Thra11 Thra11 commented Sep 7, 2020

Motivation for this change

Update to a more recent version of the plasma desktop. #94103. This update looks to be more straightforward than the update to 5.18.5 was, though it's impossible to say for sure until it's had more extensive testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Thra11 Thra11 requested a review from ttuegel as a code owner Sep 7, 2020
@ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 7, 2020

Thanks! This seems fine, but I'll need a chance to test it. We should wait to merge this until after the branches for NixOS 20.09 are made because Plasma 5.19 is not a long-term support series.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Sep 8, 2020

We've branched so no problems there.

Copy link
Member

@nyanloutre nyanloutre left a comment

Tested on my system, it's working great !

@jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Oct 13, 2020

KDE Plasma 5.20 appears to be released: https://kde.org/announcements/plasma-5.20.0

@jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Oct 13, 2020

Tested this on my system and sddm crashes with hardware.nvidia.prime.offload. It works when using nouveau instead. Tried again today and it seems to work now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.