Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iwd: 1.8 -> 1.9 #97393

Merged
merged 2 commits into from Sep 8, 2020
Merged

iwd: 1.8 -> 1.9 #97393

merged 2 commits into from Sep 8, 2020

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 7, 2020

Motivation for this change

ChangeLog: https://git.kernel.org/pub/scm/network/wireless/iwd.git/tree/ChangeLog?h=1.9

Note: before merging we have to fix the build error of ell on aarch64-linux:

ell> PASS: unit/test-endian
ell> PASS: unit/test-time
ell> PASS: unit/test-plugin
ell> PASS: unit/test-base64
ell> PASS: unit/test-random
ell> PASS: unit/test-net
ell> PASS: unit/test-hwdb
ell> PASS: unit/test-queue
ell> PASS: unit/test-dbus-util
ell> PASS: unit/test-io
ell> PASS: unit/test-netlink
ell> PASS: unit/test-util
ell> PASS: unit/test-utf8
ell> PASS: unit/test-ecdh
ell> PASS: unit/test-ecc
ell> PASS: unit/test-checksum
ell> PASS: unit/test-path
ell> PASS: unit/test-uuid
ell> PASS: unit/test-dbus-watch
ell> PASS: unit/test-ringbuf
ell> PASS: unit/test-dhcp6
ell> ./build-aux/test-driver: line 107: 20626 Aborted                 (core dumped) "$@" > $log_file 2>&1
ell> FAIL: unit/test-cipher
ell> PASS: unit/test-rtnl
ell> PASS: unit/test-string
ell> PASS: unit/test-gvariant-message
ell> PASS: unit/test-genl-msg
ell> PASS: unit/test-uintset
ell> PASS: unit/test-hashmap
ell> PASS: unit/test-settings
ell> CCLD     unit/test-dbus-properties
ell> PASS: unit/test-dir-watch
ell> PASS: unit/test-dhcp
ell> PASS: unit/test-dbus
ell> PASS: unit/test-dbus-message-fds
ell> CCLD     unit/test-dbus-message
ell> CCLD     unit/test-gvariant-util
ell> PASS: unit/test-dbus-properties
ell> PASS: unit/test-dbus-message
ell> PASS: unit/test-gvariant-util
ell> PASS: unit/test-dbus-service
ell> PASS: unit/test-main
ell> PASS: unit/test-pbkdf2
ell> ================================
ell> ell 0.33: ./test-suite.log
ell> ================================
ell> # TOTAL: 41
ell> # PASS:  40
ell> # SKIP:  0
ell> # XFAIL: 0
ell> # FAIL:  1
ell> # XPASS: 0
ell> # ERROR: 0
ell> .. contents:: :depth: 2
ell> FAIL: unit/test-cipher
ell> ======================
ell> test-cipher: unit/test-cipher.c:92: test_aes_ctr: Assertion `l_cipher_encrypt(cipher, buf, buf, FIXED_LEN)' failed.
ell> FAIL unit/test-cipher (exit status: 134)
ell> ============================================================================
ell> Testsuite summary for ell 0.33
ell> ============================================================================
ell> # TOTAL: 41
ell> # PASS:  40
ell> # SKIP:  0
ell> # XFAIL: 0
ell> # FAIL:  1
ell> # XPASS: 0
ell> # ERROR: 0
ell> ============================================================================
ell> See ./test-suite.log
ell> ============================================================================
ell> make[3]: *** [Makefile:2083: test-suite.log] Error 1
ell> make[2]: *** [Makefile:2191: check-TESTS] Error 2
ell> make[1]: *** [Makefile:2704: check-am] Error 2
ell> make: *** [Makefile:2706: check] Error 2
error: --- Error --- nix-daemon
builder for '/nix/store/hz69mdv94c9znx2hlb0s7r8c0d0q4raf-ell-0.33.drv' failed with exit code 2; last 10 log lines:
  # FAIL:  1
  # XPASS: 0
  # ERROR: 0
  ============================================================================
  See ./test-suite.log
  ============================================================================
  make[3]: *** [Makefile:2083: test-suite.log] Error 1
  make[2]: *** [Makefile:2191: check-TESTS] Error 2
  make[1]: *** [Makefile:2704: check-am] Error 2
  make: *** [Makefile:2706: check] Error 2
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ nix
error: --- Error --- nix-daemon
1 dependencies of derivation '/nix/store/a1ivyqk0974jxwndwp9fnxxlkzrbnyi2-iwd-1.9.drv' failed to build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Ma27 added 2 commits Sep 7, 2020
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Sep 8, 2020

@GrahamcOfBorg build iwd

Hmm, managed to build iwd now as /nix/store/319bk8jvqyidbb2xbfmissdbhls935az-iwd-1.9 on the community builder and it doesn't fail anymore. Rebuilding here to see what's happening now.

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Sep 8, 2020

iwd builds here as well now. So let's merge it.

@Ma27 Ma27 merged commit b852586 into NixOS:master Sep 8, 2020
21 of 23 checks passed
21 of 23 checks passed
tests tests
Details
action
Details
ell, ell.passthru.tests, iwd, iwd.passthru.tests on x86_64-darwin
Details
iwd on x86_64-darwin
Details
ell, ell.passthru.tests, iwd, iwd.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
ell, ell.passthru.tests, iwd, iwd.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a59a88c"; rev="a59a88cf3e9b947627031a3d388b75bc4db39d05"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a59a88c"; rev="a59a88cf3e9b947627031a3d388b75bc4db39d05"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a59a88c"; rev="a59a88cf3e9b947627031a3d388b75bc4db39d05"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a59a88c"; rev="a59a88cf3e9b947627031a3d388b75bc4db39d05"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a59a88c"; rev="a59a88cf3e9b947627031a3d388b75bc4db39d05"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a59a88c"; rev="a59a88cf3e9b947627031a3d388b75bc4db39d05"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a59a88c"; rev="a59a88cf3e9b947627031a3d388b75bc4db39d05"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
iwd on aarch64-linux Success
Details
iwd on x86_64-linux Success
Details
@Ma27 Ma27 deleted the Ma27:bump-iwd branch Sep 8, 2020
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Sep 8, 2020

Pushed to 20.09 as 3f4a519, 6ba1612.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.