Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnscontrol: 3.2.0 -> 3.3.0, add me as maintainer #97394

Merged
merged 3 commits into from Sep 17, 2020

Conversation

@SuperSandro2000
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 commented Sep 7, 2020

Motivation for this change

I need a feature which is only in 3.3.0.

The deps.nix is generated using nix-community/vgo2nix#42 because the master version fails with newer go.mods and the vendor dir got removed between 3.2.0 and 3.3.0. This should help updating other go modules in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ehmry
Copy link
Member

@ehmry ehmry commented Sep 16, 2020

Is it possible to use buildGoModule instead of buildGoPackage? https://nixos.org/manual/nixpkgs/stable/#ssec-go-modules 1.5K lines of deps seems excessive to me.

@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:dnscontrol-3.3.0 branch 2 times, most recently from 356f349 to 85534d6 Sep 16, 2020
@SuperSandro2000
Copy link
Contributor Author

@SuperSandro2000 SuperSandro2000 commented Sep 16, 2020

Is it possible to use buildGoModule instead of buildGoPackage?

Thanks for the hint! This makes this update way smaller and better to review.

@ofborg ofborg bot requested a review from kalbasit Sep 16, 2020
@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:dnscontrol-3.3.0 branch from 85534d6 to 139143c Sep 17, 2020
@ehmry ehmry merged commit 2a14d21 into NixOS:master Sep 17, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
dnscontrol, dnscontrol.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
dnscontrol, dnscontrol.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="139143c"; rev="139143cabf74db27e5d4ac1cabd1e380570ed4a7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="139143c"; rev="139143cabf74db27e5d4ac1cabd1e380570ed4a7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="139143c"; rev="139143cabf74db27e5d4ac1cabd1e380570ed4a7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="139143c"; rev="139143cabf74db27e5d4ac1cabd1e380570ed4a7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="139143c"; rev="139143cabf74db27e5d4ac1cabd1e380570ed4a7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="139143c"; rev="139143cabf74db27e5d4ac1cabd1e380570ed4a7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="139143c"; rev="139143cabf74db27e5d4ac1cabd1e380570ed4a7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@SuperSandro2000 SuperSandro2000 deleted the SuperSandro2000:dnscontrol-3.3.0 branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.