Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.google_resumable_media: v0.7.1 -> v1.0.0, python3Packages.google_crc32c: init at v1.0.0 #97529

Conversation

@siriobalmelli
Copy link
Contributor

@siriobalmelli siriobalmelli commented Sep 9, 2020

Commit f6514b5 upgraded python3Packages.google_resumable_media and broke it:

ERROR: Could not find a version that satisfies the requirement google-crc32c<0.2dev,>=0.1.0; python_version >= "3.5" (from google-resumable-media==0.7.1) (from versions: none)
ERROR: No matching distribution found for google-crc32c<0.2dev,>=0.1.0; python_version >= "3.5" (from google-resumable-media==0.7.1)
builder for '/nix/store/diqkd6pk13ihmd5lgic98d88h0frcgv8-python3.8-google-resumable-media-0.7.1.drv' failed with exit code 1

This patch series:

  • upgrades python3Packages.google_resumable_media to the latest version
  • adds the python3Packages.google_crc32c dependency introduced in f6514b5
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
Add new google_crc32c dependency.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli
Copy link
Contributor Author

@siriobalmelli siriobalmelli commented Oct 5, 2020

This was later done and committed separately as 2468315 and 908d8c3

@siriobalmelli siriobalmelli deleted the siriobalmelli-foss:fix/google_resumable_media branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants