Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/postgresql: fix inaccurate docs for authentication #97622

Merged
merged 2 commits into from Oct 31, 2020

Conversation

@lf-
Copy link
Contributor

@lf- lf- commented Sep 10, 2020

We actually use peer authentication, then md5 based authentication.
trust is not used.

This note was inaccurate when it was introduced into the docs.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lf-
Copy link
Contributor Author

@lf- lf- commented Sep 10, 2020

cc @danbst

We actually use peer authentication, then md5 based authentication.
trust is not used.
@lf- lf- force-pushed the fix-postgres-docs branch from a30790b to 5a8ee46 Sep 10, 2020
@aanderse aanderse requested a review from aszlig Sep 10, 2020
aszlig
aszlig approved these changes Sep 14, 2020
nixos/modules/services/databases/postgresql.nix Outdated Show resolved Hide resolved
Co-authored-by: aszlig <aszlig@redmoonstudios.org>
@lf-
Copy link
Contributor Author

@lf- lf- commented Sep 14, 2020

@aszlig let me know if I have to squash this now before it can be merged. Thanks for the markup suggestion!

@worldofpeace worldofpeace merged commit 2df221e into NixOS:master Oct 31, 2020
17 checks passed
mkaito pushed a commit to serokell/nixpkgs that referenced this issue Nov 19, 2020
* nixos/postgresql: fix inaccurate docs for authentication

We actually use peer authentication, then md5 based authentication.
trust is not used.

* Use a link for mkForce docs

Co-authored-by: aszlig <aszlig@redmoonstudios.org>

Co-authored-by: lf- <lf-@users.noreply.github.com>
Co-authored-by: aszlig <aszlig@redmoonstudios.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants