Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fac-build: init at 0.5.3 #97868

Merged
merged 2 commits into from Sep 16, 2020
Merged

fac-build: init at 0.5.3 #97868

merged 2 commits into from Sep 16, 2020

Conversation

@dpercy
Copy link

dpercy commented Sep 12, 2020

Motivation for this change

Add fac build system: http://sites.science.oregonstate.edu/~roundyd/fac/

The Nix package name "fac" is taken, so does "fac-build" make sense instead?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
      (fac only supports Linux today.)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

danieldk left a comment

Thank you for your first contribution 👍

I have added some requested changes.

pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
@dpercy dpercy mentioned this pull request Sep 15, 2020
@dpercy dpercy force-pushed the dpercy:fac-build branch from 807c722 to 072b6ce Sep 16, 2020
David Percy
@dpercy dpercy force-pushed the dpercy:fac-build branch from 072b6ce to 16beff4 Sep 16, 2020
@dpercy
Copy link
Author

dpercy commented Sep 16, 2020

Thanks for the feedback! I think I've addressed everything so far.

Copy link
Member

danieldk left a comment

LGTM. Thanks a lot!

Result of nixpkgs-review pr 97868 1

1 package built:
  • fac-build
@danieldk danieldk merged commit 917a183 into NixOS:master Sep 16, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
fac-build, fac-build.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
fac-build, fac-build.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="16beff4"; rev="16beff405dd78a96b1f61d92195d87f1d32da68c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="16beff4"; rev="16beff405dd78a96b1f61d92195d87f1d32da68c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="16beff4"; rev="16beff405dd78a96b1f61d92195d87f1d32da68c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="16beff4"; rev="16beff405dd78a96b1f61d92195d87f1d32da68c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="16beff4"; rev="16beff405dd78a96b1f61d92195d87f1d32da68c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="16beff4"; rev="16beff405dd78a96b1f61d92195d87f1d32da68c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="16beff4"; rev="16beff405dd78a96b1f61d92195d87f1d32da68c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dpercy
Copy link
Author

dpercy commented Sep 16, 2020

Thanks!

@dpercy dpercy deleted the dpercy:fac-build branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.