Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector: 0.8.1 -> 0.10.0; fix Darwin build #97944

Closed
wants to merge 1 commit into from

Conversation

@happysalada
Copy link
Contributor

@happysalada happysalada commented Sep 14, 2020

Motivation for this change

darwin build is broken https://hydra.nixos.org/build/126541180

Things done

update dependency to latest released (0.10.0)

remove deprecated feature shiplift @thoughtpolice let me know if I'm wrong there

add buildInput for darwin

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [x ] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot added the 6.topic: darwin label Sep 14, 2020
@thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Sep 14, 2020

I was looking into this myself last week; thanks for beating me to it!

@thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Sep 14, 2020

@GrahamcOfBorg build vector

2 similar comments
@thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Sep 15, 2020

@GrahamcOfBorg build vector

@thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Sep 23, 2020

@GrahamcOfBorg build vector

@thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Oct 10, 2020

@happysalada Hi, sorry for taking so long to get back to this! I would have merged it earlier if not for the eval failure; at first I thought the problem was an ofborg issue but clearly I just wasn't reading things properly, or something.

The main thing is that there needed to be a small patch to the testsuite (to fix attempts to do DNS resolution during checkPhase) and a small patch to all-packages.nix to add a missing CoreServices argument. Together, these let the build pass.

I've amended your original commit, and this has been merged to master as d892551 (retaining your authorship), so I'll close this. Sorry again about the wait!

@happysalada
Copy link
Contributor Author

@happysalada happysalada commented Oct 10, 2020

@thoughtpolice Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.