Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: 246.4 -> 246.6 #97989

Merged
merged 3 commits into from Oct 5, 2020
Merged

systemd: 246.4 -> 246.6 #97989

merged 3 commits into from Oct 5, 2020

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Sep 14, 2020

This bumps systemd to the latest stable maintenance release.

d0f0f048ec (tag: v246.5, systemd-stable/v246-stable) sd-path: use ROOTPREFIX without suffixed slash
e662cf6d51 hashmap: make sure to initialize shared hash key atomically
da310c6b45 socket: downgrade log warnings about inability to set socket buffer sizes
ab6fcd9135 core: fix securebits setting
4f6925484d capability-util: add new function for raising setpcap
771436884d network: do not add prefix to RA if radv is not configured
fb2afc5f30 man: document the random delay of persistent timers
b2006ddc8f test-network: add test for ENOBUFS issue #17012
8758580ef5 backlight: do not claim that ID_BACKLIGHT_CLAMP= property is not set
57fc184a6c fs-util,tmpfiles: fix error handling of fchmod_opath()
db0f031e70 bootctl: don't accidentally propagate errors in "bootctl status"
3e2c806681 ethtool-util: don't pass error value that isn't used to log_syntax
b671730edb network: don't fail on various config parse errors
0ad86030c5 man: document that sd_bus_message_close_container() may only be called at end of container
f3da018017 cryptsetup: Fix null pointer dereference (#16987)
6f65eaf9c2 core: fix set keep caps for ambient capabilities
08338a234e core: fix comments on ambient capabilities
f0e6d9876d network: make log_link_error() or friends return void
35766dc61b core: make log_unit_error() or friends return void
3ed10b2ee8 core/slice: explicitly specify return value
2f6406914b udev: do not discard const qualifier
07671aa4cc sd-device: make log_device_error() or friends return void
d4bea73972 udev: explicitly specify return value
7db399be1e udev: return negative errno for invalid EVDEV_ABS_XXX= property
8c8d188e85 udev: make log_rule_error() or friends return void
4921375fd3 socket: fix copy/paste error
0f7fd97749 udev: warn if failed to set buffer size for device monitor
fc763d38d8 network: increase receive buffer size for device monitor
3bf7797f1f network: do not start device monitor if /sys is read-only
ebc0729c6a network: honor the buffer size specified in networkd.socket
ef3d2e178b core/socket: use fd_set_{rcv,snd}buf()
5dd4cc4b10 sd-device-monitor: use fd_set_rcvbuf()
fe9b92e566 util: introduce fd_set_{snd,rcv}buf()
4dcae66688 util: try to set with SO_{RCV,SND}BUFFORCE when requested size is larger than the kernel limit
4b6b523946 util: refuse to set too large value for socket buffer size
b4be8edb45 network: ignore error on increasing netlink receive buffer size
5ce47fb491 tree-wide: if get_block_device() returns zero devno, check for it in all cases
8ea6ec18e7 btrfs: if BTRFS_IOC_DEV_INFO returns /dev/root generate a friendly error message
e1ff4947d2 basic/log: make log_{info,warning,...} return void
8019995e9a tree-wide: correct cases where return log_{error,warning} is used without value
932f4c3e8b test-execute/exec-dynamicuser-statedir.service: fix quoting
16b9426f70 man: fix quickhelp listing in sysusers.d(5)
bde903d9e9 network: fix NDisc handling for the case when multiple routers exist
c965063b64 network: expose route_{hash,compare}func()
6d24a40669 network: expose address
{hash,compare}func()
054838a2e0 util: expose in6_addr
{hash,compare}_func()
58bd4a70de network: fixes gateway assignment through DHCPv4
8ad5382fe3 bash-completion: resolvectl: support 'log-level' command
a98bd75072 resolvectl: add 'log-level' to help message
78262fe807 core/socket: we may get ENOTCONN from socket_instantiate_service()
fecb3f00c4 homed: remember the secret even when the for_state is FIXATING_FOR_ACQUIRE

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
andir and others added 3 commits Sep 27, 2020
Update to latest stable version. Changes:

d0f0f048ec sd-path: use ROOTPREFIX without suffixed slash
e662cf6d51 hashmap: make sure to initialize shared hash key atomically
da310c6b45 socket: downgrade log warnings about inability to set socket buffer sizes
ab6fcd9135 core: fix securebits setting
4f6925484d capability-util: add new function for raising setpcap
771436884d network: do not add prefix to RA if radv is not configured
fb2afc5f30 man: document the random delay of persistent timers
b2006ddc8f test-network: add test for ENOBUFS issue NixOS#17012
8758580ef5 backlight: do not claim that ID_BACKLIGHT_CLAMP= property is not set
57fc184a6c fs-util,tmpfiles: fix error handling of fchmod_opath()
db0f031e70 bootctl: don't accidentally propagate errors in "bootctl status"
3e2c806681 ethtool-util: don't pass error value that isn't used to log_syntax
b671730edb network: don't fail on various config parse errors
0ad86030c5 man: document that sd_bus_message_close_container() may only be called at end of container
f3da018017 cryptsetup: Fix null pointer dereference (NixOS#16987)
6f65eaf9c2 core: fix set keep caps for ambient capabilities
08338a234e core: fix comments on ambient capabilities
f0e6d9876d network: make log_link_error() or friends return void
35766dc61b core: make log_unit_error() or friends return void
3ed10b2ee8 core/slice: explicitly specify return value
2f6406914b udev: do not discard const qualifier
07671aa4cc sd-device: make log_device_error() or friends return void
d4bea73972 udev: explicitly specify return value
7db399be1e udev: return negative errno for invalid EVDEV_ABS_XXX= property
8c8d188e85 udev: make log_rule_error() or friends return void
4921375fd3 socket: fix copy/paste error
0f7fd97749 udev: warn if failed to set buffer size for device monitor
fc763d38d8 network: increase receive buffer size for device monitor
3bf7797f1f network: do not start device monitor if /sys is read-only
ebc0729c6a network: honor the buffer size specified in networkd.socket
ef3d2e178b core/socket: use fd_set_{rcv,snd}buf()
5dd4cc4b10 sd-device-monitor: use fd_set_rcvbuf()
fe9b92e566 util: introduce fd_set_{snd,rcv}buf()
4dcae66688 util: try to set with SO_{RCV,SND}BUFFORCE when requested size is larger than the kernel limit
4b6b523946 util: refuse to set too large value for socket buffer size
b4be8edb45 network: ignore error on increasing netlink receive buffer size
5ce47fb491 tree-wide: if get_block_device() returns zero devno, check for it in all cases
8ea6ec18e7 btrfs: if BTRFS_IOC_DEV_INFO returns /dev/root generate a friendly error message
e1ff4947d2 basic/log: make log_{info,warning,...} return void
8019995e9a tree-wide: correct cases where return log_{error,warning} is used without value
932f4c3e8b test-execute/exec-dynamicuser-statedir.service: fix quoting
16b9426f70 man: fix quickhelp listing in sysusers.d(5)
bde903d9e9 network: fix NDisc handling for the case when multiple routers exist
c965063b64 network: expose route_{hash,compare}_func()
6d24a40669 network: expose address_{hash,compare}_func()
054838a2e0 util: expose in6_addr_{hash,compare}_func()
58bd4a70de network: fixes gateway assignment through DHCPv4
8ad5382fe3 bash-completion: resolvectl: support 'log-level' command
a98bd75072 resolvectl: add 'log-level' to help message
78262fe807 core/socket: we may get ENOTCONN from socket_instantiate_service()
fecb3f00c4 homed: remember the secret even when the for_state is FIXATING_FOR_ACQUIRE
This reverts commit b32701b.

That fix has been included upstream in 246.5.
@flokli
Copy link
Contributor Author

@flokli flokli commented Sep 27, 2020

Meanwhile 246.6 was released, containing the following fixes:

2ee1c57c4f (tag: v246.6, systemd-stable/v246-stable) kernel-install/90-loaderentry: fix when /boot is not mountpoint
a2a8802abe homed: make clean that --storage=directory --image-path=/dev/some-block-device is not supported
e1df274a76 homed: make sure our worker processes finish before we exit
f2763ff6cd nspawn: fix fd leak on failure path
6f9c8af500 nspawn: check return of setsid()
31875b3cb0 dissect: is_loop_device() returns negative on error, don't mistake that is true
418cf0e78c dissect: always invalidate secondary arch partitions if we found primary arch
1d17c00260 util: wireguard is merged into upstream kernel
48a308b76a repart: don't mark image files generated with --empty=create executable
9353607ef3 man: substitute path to rc.local in the man page
f2b9345cd2 meson: RC_LOCAL_SCRIPT_PATH_START to RC_LOCAL_PATH
b0fff9012a socket-proxy: allow localhost addresses
5e8bf33de1 sd-bus: allow localhost addresses
ad77a988f2 fstab-generator: add 'nofail' when  NFS 'bg' option is used
d08f6fddc0 busctl: add missing shortopt -l
64d58480ac socket-util: reset length argument for second getsockopt call in fd_[gs]et_rcvbuf
0046c58334 test: use pclose() for popen()
689d2e061b core: propagate unit start limit hit state to triggering path unit
2f53d690ea core: propagate triggered unit in more load states
a06cf9a5ba bootctl: handle if LoaderSystemToken is invalid for some reason
e2c0023dd2 test-fileio: test test strings with shell, too
251b96c9b5 test-env-file: add test that tests our env file read + writer + shell against each other
4d1922d8bb env-file: bring our decoding of double-quoted strings in env files in line with shell
281581cd74 test-fileio: use test strings that are actually valid in shell
366d38d8ed man: document that RemainAfterElapse=no means that also the triggered unit needs to deactivate

I rebased on top of latest staging and added a commit for that bump.

@flokli flokli changed the title systemd: 246.4 -> 246.5 systemd: 246.4 -> 246.6 Sep 27, 2020
@flokli flokli requested review from NinjaTrappeur and arianvp Sep 27, 2020
@andir andir merged commit 2d92e69 into NixOS:staging Oct 5, 2020
19 of 20 checks passed
@flokli flokli deleted the systemd-246.5 branch Oct 10, 2020
@mmilata
Copy link
Member

@mmilata mmilata commented Nov 22, 2020

Would it be possible to backport to 20.09? There's #99127 causing sshd to be unavailable, which I imagine can inconvenience a lot of people. Or is it be better to backport just systemd/systemd-stable@78262fe?

@flokli
Copy link
Contributor Author

@flokli flokli commented Nov 22, 2020

Backporting point releases to 20.09 is fine.

@mmilata can you open a PR against staging-20.09 with a cherry-pick -x of these commits?

@mmilata mmilata mentioned this pull request Nov 22, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants