Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manix: init at 0.6.2 #98058

Merged
merged 2 commits into from Sep 16, 2020
Merged

manix: init at 0.6.2 #98058

merged 2 commits into from Sep 16, 2020

Conversation

@mlvzk
Copy link
Contributor

mlvzk commented Sep 15, 2020

Motivation for this change

Init manix, a CLI documentation searcher for Nix. https://github.com/mlvzk/manix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mlvzk mlvzk force-pushed the mlvzk:init-manix branch from 0b5a46e to 0c92513 Sep 15, 2020
@mlvzk mlvzk force-pushed the mlvzk:init-manix branch from 0c92513 to 92ba610 Sep 15, 2020
Copy link
Contributor

symphorien left a comment

ran nix-review and it works


meta = with stdenv.lib; {
description = "A Fast Documentation Searcher for Nix";
homepage = "https://github.com/mlvzk/manix";

This comment has been minimized.

@samuelgrf

samuelgrf Sep 15, 2020 Contributor

-    homepage    = "https://github.com/mlvzk/manix";
+    homepage    = src.meta.homepage;
@ryantm
Copy link
Member

ryantm commented Sep 16, 2020

Result of nixpkgs-review pr 98058 1

1 package built:
- manix
@ryantm ryantm merged commit 40ab795 into NixOS:master Sep 16, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
manix, manix.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="92ba610"; rev="92ba610833f1d4dd01bf31a2f4f52a08c9cf6e29"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="92ba610"; rev="92ba610833f1d4dd01bf31a2f4f52a08c9cf6e29"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="92ba610"; rev="92ba610833f1d4dd01bf31a2f4f52a08c9cf6e29"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="92ba610"; rev="92ba610833f1d4dd01bf31a2f4f52a08c9cf6e29"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="92ba610"; rev="92ba610833f1d4dd01bf31a2f4f52a08c9cf6e29"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="92ba610"; rev="92ba610833f1d4dd01bf31a2f4f52a08c9cf6e29"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="92ba610"; rev="92ba610833f1d4dd01bf31a2f4f52a08c9cf6e29"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
manix, manix.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.