Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esphome: 1.14.5 -> 1.15.0 #98070

Closed
wants to merge 1 commit into from
Closed

esphome: 1.14.5 -> 1.15.0 #98070

wants to merge 1 commit into from

Conversation

@makefu
Copy link
Contributor

@makefu makefu commented Sep 15, 2020

upstream switched from setup.py to define the requirements to requirements.txt

Motivation for this change

esphome 1.15.0 comes with a lot cool new modules

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • tested building esp32 with new modules
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
upstream switched from setup.py to define the requirements to requirements.txt
Copy link
Member

@mweinelt mweinelt left a comment

LGTM

};
};
};

in python.pkgs.buildPythonApplication rec {
pname = "esphome";
version = "1.14.5";
version = "1.15.0";
Copy link
Member

@mweinelt mweinelt Oct 1, 2020

Please refresh, 1.15.2 is out.

1000101
1000101 approved these changes Oct 3, 2020
Copy link
Member

@1000101 1000101 left a comment

I've cherry-picked this commit and bumped the version in #99477

@1000101 1000101 mentioned this pull request Oct 3, 2020
10 tasks
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 3, 2020

Superseded by #99477.

@mweinelt mweinelt closed this Oct 3, 2020
@makefu makefu deleted the pkgs/esphome/bump branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants