Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maestral-gui: Update Qt libs to 5.15 #98073

Closed
wants to merge 1 commit into from

Conversation

@SFrijters
Copy link
Member

SFrijters commented Sep 15, 2020

Motivation for this change

Attempts to fix #98067 , which was broken by c1a0dfa .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SFrijters SFrijters requested review from peterhoeg and petabyteboy Sep 15, 2020
This fixes a core dump introduced by c1a0dfa.
@SFrijters SFrijters force-pushed the SFrijters:maestral-gui-qt515 branch from 6a53719 to 28f4d37 Sep 15, 2020
@SFrijters SFrijters mentioned this pull request Sep 16, 2020
4 of 10 tasks complete
@SFrijters
Copy link
Member Author

SFrijters commented Sep 16, 2020

c1a0dfa has been reverted in a4e50bb, this should no longer be needed.

@SFrijters SFrijters closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.