Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordgrinder: Correct build failure #98078

Closed
wants to merge 2 commits into from

Conversation

@Pamplemousse
Copy link
Member

Pamplemousse commented Sep 16, 2020

Motivation for this change

Update wordgrinder for it to build properly.
ZHF: #97479

Opened davidgiven/wordgrinder#114 upstream for an elegant way to fix the failure. (unnecessary)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
They don't correspond to any variables (anymore) in the `Makefile`:
https://github.com/davidgiven/wordgrinder/blob/0.7.2/Makefile

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@Pamplemousse Pamplemousse changed the title [WIP] wordgrinder: Correct build failure wordgrinder: Correct build failure Sep 16, 2020
@risicle
Copy link
Contributor

risicle commented Sep 16, 2020

#97911 ?

@Pamplemousse Pamplemousse deleted the Pamplemousse:wordgrinder branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.