Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traefik: fix dashboard by using source releases #98092

Open
wants to merge 1 commit into
base: master
from

Conversation

@bennofs
Copy link
Contributor

bennofs commented Sep 16, 2020

The traefik dashboard depends on static files built with npm.
The source releases included the prebundled static files ,
so switching to them fixes the issue.

Motivation for this change

The inbuilt traefik dashboard does not work with the nix package (404 not found). This is because the static files in static/ of the source repo are not built by the package. We can fix this by using the source package with bundled javascripts from github.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The traefik dashboard depends on static files built with npm.
The source releases included the prebundled static files ,
so switching to them fixes the issue.
@maxeaubrey
Copy link
Contributor

maxeaubrey commented Sep 16, 2020

Result of nixpkgs-review pr 98092 1

1 package built:
  • traefik
Copy link
Contributor

maxeaubrey left a comment

Looks to be working, the test passes.

Fixes #41378 btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.