Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portmod: init at 2.0_beta7 #98093

Open
wants to merge 6 commits into
base: master
from
Open

portmod: init at 2.0_beta7 #98093

wants to merge 6 commits into from

Conversation

@marius851000
Copy link
Contributor

marius851000 commented Sep 16, 2020

Motivation for this change

wanted to add the portmod package. I use it, and wanted it to be in the nixpkgs.

Things done

mainly in additional to portmod, add patool.

I was able to install the meta-momw/expanded-vanilla , but with some modification in the environment: needed to set "TMPDIR=/tmp" (the default temp dir doesn't have enought size) and to have unrar in the PATH.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@IvarWithoutBones
Copy link
Contributor

IvarWithoutBones commented Sep 16, 2020

Result of nixpkgs-review pr 98093 1

1 package failed to build:
  • python27Packages.redbaron
15 packages built:
  • patool (python38Packages.patool)
  • portmod
  • python27Packages.baron
  • python27Packages.patool
  • python27Packages.pypblib
  • python27Packages.python-sat
  • python37Packages.baron
  • python37Packages.patool
  • python37Packages.pypblib
  • python37Packages.python-sat
  • python37Packages.redbaron
  • python38Packages.baron
  • python38Packages.pypblib
  • python38Packages.python-sat
  • python38Packages.redbaron

python27Packages.redbaron error:

[2/11/31 built, 149 copied (1588.1/1588.6 MiB), 285.6 MiB DL] building python3.7-python-sat-0.1.6.dev6 (buildPhase): |       ^~~
builder for '/nix/store/1pi10m6myd6rcjw7k5iz9nxwm16nzsdr-python2.7-redbaron-0.9.2.drv' failed with exit code 2; last 10 log lines:
  HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
  ____________________ ERROR collecting tests/test_setter.py _____________________
  import file mismatch:
  imported module 'tests.test_setter' has this __file__ attribute:
    /home/psycojoker/code/python/redbaron/tests/test_setter.py
  which is not the same as the test file we want to collect:
    /build/redbaron-0.9.2/tests/test_setter.py
  HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
  !!!!!!!!!!!!!!!!!!! Interrupted: 13 errors during collection !!!!!!!!!!!!!!!!!!!
  =========================== 13 error in 8.46 seconds ===========================
cannot build derivation '/nix/store/jx4pgvd31fy01ldzvplk4kg8qizcf7xh-env.drv': 1 dependencies couldn't be built
[29 built (1 failed), 149 copied (1588.1 MiB), 285.6 MiB DL]
error: build of '/nix/store/jx4pgvd31fy01ldzvplk4kg8qizcf7xh-env.drv' failed
@marius851000 marius851000 force-pushed the marius851000:portmod branch from 97f72bd to 829dd5b Sep 17, 2020
@marius851000
Copy link
Contributor Author

marius851000 commented Sep 17, 2020

that should be fixed, thank.

Copy link
Contributor

IvarWithoutBones left a comment

Result of nixpkgs-review pr 98093 1

16 packages built:
  • patool (python38Packages.patool)
  • portmod
  • python27Packages.baron
  • python27Packages.patool
  • python27Packages.pypblib
  • python27Packages.python-sat
  • python27Packages.redbaron
  • python37Packages.baron
  • python37Packages.patool
  • python37Packages.pypblib
  • python37Packages.python-sat
  • python37Packages.redbaron
  • python38Packages.baron
  • python38Packages.pypblib
  • python38Packages.python-sat
  • python38Packages.redbaron
@jonringer
Copy link
Contributor

jonringer commented Sep 18, 2020

I take back the hash reviews, apparently master has been updated with a minver which supports 64bit base hashes

@marius851000 marius851000 force-pushed the marius851000:portmod branch from 829dd5b to ad34a75 Sep 21, 2020
@marius851000
Copy link
Contributor Author

marius851000 commented Sep 21, 2020

Thank. I fixed the issue you reported (exluding the hash). Now I know why hash are shorter now.
Seem baron have issue with python 2.7. Will solve this.
solved !

@marius851000 marius851000 force-pushed the marius851000:portmod branch from ad34a75 to adc330d Sep 21, 2020
@marius851000 marius851000 force-pushed the marius851000:portmod branch from adc330d to b6ac9a3 Sep 25, 2020
@marius851000
Copy link
Contributor Author

marius851000 commented Sep 25, 2020

That's done. Thank again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.