Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.19.1 -> 1.19.2 #98097

Merged
merged 1 commit into from Sep 16, 2020
Merged

Conversation

@ajs124
Copy link
Member

ajs124 commented Sep 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124 ajs124 marked this pull request as ready for review Sep 16, 2020
@ajs124 ajs124 requested a review from Ma27 Sep 16, 2020
@dali99
dali99 approved these changes Sep 16, 2020
@fadenb
fadenb approved these changes Sep 16, 2020
Copy link
Member

fadenb left a comment

Ran 1142 tests in 511.921s

PASSED (skips=5, successes=1137)
@mweinelt
Copy link
Member

mweinelt commented Sep 16, 2020

Ran 1142 tests in 633.275s

PASSED (skips=5, successes=1137)
/nix/store/njykssngnvk9w4zilwp4n0711k4a9415-vm-test-run-matrix-synapse

LGTM

Copy link
Contributor

martinetd left a comment

cherry-picked on 20.03 works-for-me (build tests as quoted previously and actual functionality seems OK)

@tokudan tokudan mentioned this pull request Sep 16, 2020
3 of 10 tasks complete
@mguentner
Copy link
Contributor

mguentner commented Sep 16, 2020

cherry-picked on 20.03 works-for-me (build tests as quoted previously and actual functionality seems OK)

Can confirm

@tokudan tokudan mentioned this pull request Sep 16, 2020
0 of 10 tasks complete
@ajs124 ajs124 merged commit 233ae7b into NixOS:master Sep 16, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
matrix-synapse, matrix-synapse.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21779ae"; rev="21779aece5848870fd47b7dbfb55823e7355f6a8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21779ae"; rev="21779aece5848870fd47b7dbfb55823e7355f6a8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21779ae"; rev="21779aece5848870fd47b7dbfb55823e7355f6a8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21779ae"; rev="21779aece5848870fd47b7dbfb55823e7355f6a8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21779ae"; rev="21779aece5848870fd47b7dbfb55823e7355f6a8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21779ae"; rev="21779aece5848870fd47b7dbfb55823e7355f6a8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21779ae"; rev="21779aece5848870fd47b7dbfb55823e7355f6a8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
matrix-synapse, matrix-synapse.passthru.tests on x86_64-linux Success
Details
@ajs124 ajs124 deleted the helsinki-systems:upd/matrix-synapse branch Sep 16, 2020
@Ma27
Copy link
Member

Ma27 commented Sep 17, 2020

@ajs124 thanks a lot for taking care of this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.