Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tinydb: 3.14.1 -> 4.1.1 #98104

Merged
merged 1 commit into from Oct 2, 2020
Merged

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Sep 16, 2020

Motivation for this change
  • Fix license
  • Update version
  • Update homepage & URL links
  • Disable on python2.7 (no longer supported).
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
* Fix license
* Update version
* Update homepage & URL links
* Disable on python2.7 (no longer supported).
@marcus7070
Copy link
Member

@marcus7070 marcus7070 commented Sep 16, 2020

Builds with python 3.6 to 3.8 and passes tests on NixOS. Thanks @drewrisinger.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 2, 2020

Yeah, looks pretty good, thanks!

Result of nixpkgs-review pr 98104 1

2 packages built:
  • python37Packages.tinydb
  • python38Packages.tinydb

@mweinelt mweinelt merged commit 4579ac5 into NixOS:master Oct 2, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants