Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk-python-derivation: document pyproject format #98106

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@drewrisinger
Copy link
Contributor

drewrisinger commented Sep 16, 2020

Motivation for this change

Optional setting of format == "pyproject" had been documented
in the manual, but it weren't listed in the function header for
mk-python-derivation.nix.

I'm not changing the manual for "egg" because "egg" is effectively deprecated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Optional setting of format == "pyproject", "egg" had been documented
in the manual, but they weren't listed in the function header for
``mk-python-derivation.nix``.
@drewrisinger drewrisinger requested a review from FRidh as a code owner Sep 16, 2020
@drewrisinger drewrisinger force-pushed the drewrisinger:dr-pr-pyderiv-docs branch from 3428d90 to 176aadb Sep 16, 2020
@FRidh FRidh merged commit 60df61b into NixOS:master Sep 16, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@drewrisinger drewrisinger deleted the drewrisinger:dr-pr-pyderiv-docs branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.