Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verilator: 4.040 -> 4.100 #98109

Merged
merged 1 commit into from Sep 16, 2020
Merged

verilator: 4.040 -> 4.100 #98109

merged 1 commit into from Sep 16, 2020

Conversation

@Pamplemousse
Copy link
Member

Pamplemousse commented Sep 16, 2020

Motivation for this change

Update to newer version; Actually builds now.
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@thoughtpolice
Copy link
Member

thoughtpolice commented Sep 16, 2020

I literally have no idea what broke this package; as you can see here it was building fine with 4.040 when I committed it. Sigh...

Thank you for the update, I appreciate it.

@thoughtpolice thoughtpolice merged commit f1f1396 into NixOS:master Sep 16, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
verilator, verilator.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9839c0b"; rev="9839c0b292a35f77aefe8c1ff319a455ba6dcbee"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9839c0b"; rev="9839c0b292a35f77aefe8c1ff319a455ba6dcbee"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9839c0b"; rev="9839c0b292a35f77aefe8c1ff319a455ba6dcbee"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9839c0b"; rev="9839c0b292a35f77aefe8c1ff319a455ba6dcbee"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9839c0b"; rev="9839c0b292a35f77aefe8c1ff319a455ba6dcbee"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9839c0b"; rev="9839c0b292a35f77aefe8c1ff319a455ba6dcbee"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9839c0b"; rev="9839c0b292a35f77aefe8c1ff319a455ba6dcbee"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
verilator, verilator.passthru.tests on x86_64-linux Success
Details
@risicle
Copy link
Contributor

risicle commented Sep 16, 2020

WFM macos 10.14 ohtoolate

@Pamplemousse Pamplemousse deleted the Pamplemousse:verilator branch Sep 16, 2020
@Pamplemousse Pamplemousse mentioned this pull request Sep 18, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.