Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-controller: fix missing icons (librsvg) #98116

Merged
merged 1 commit into from Sep 21, 2020

Conversation

@timjrd
Copy link
Contributor

timjrd commented Sep 16, 2020

Motivation for this change

Fix missing SVG icons apparently due to redundant declaration/loading of librsvg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@timjrd
Copy link
Contributor Author

timjrd commented Sep 16, 2020

Maybe I should ping @orivej and @rnhmjoj for review.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 16, 2020

Uhm, I didn't write that line (@orivej did) so I'm not sure on why it's needed. Removing it may have some unintended side effect...

@orivej
orivej approved these changes Sep 18, 2020
Copy link
Contributor

orivej left a comment

I have not investigated this, but your change looks OK since 0c2ede9#diff-036410e9211b4336186fc613f7200b12

@rnhmjoj rnhmjoj merged commit 799f149 into NixOS:master Sep 21, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
sc-controller, sc-controller.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81c2d88"; rev="81c2d88d7a1ddd5fb98f85009a3640e1bd1b3a74"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81c2d88"; rev="81c2d88d7a1ddd5fb98f85009a3640e1bd1b3a74"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81c2d88"; rev="81c2d88d7a1ddd5fb98f85009a3640e1bd1b3a74"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81c2d88"; rev="81c2d88d7a1ddd5fb98f85009a3640e1bd1b3a74"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81c2d88"; rev="81c2d88d7a1ddd5fb98f85009a3640e1bd1b3a74"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81c2d88"; rev="81c2d88d7a1ddd5fb98f85009a3640e1bd1b3a74"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81c2d88"; rev="81c2d88d7a1ddd5fb98f85009a3640e1bd1b3a74"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sc-controller, sc-controller.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.