Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.cryptography_2_9: Allow to use version 2.9 with Python3 #98118

Closed
wants to merge 1 commit into from

Conversation

@Pamplemousse
Copy link
Member

Pamplemousse commented Sep 16, 2020

Motivation for this change

Allow cryptography to be used as a dependency by python modules with the version requirements:

  • cryptography<3
  • python>3
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Pamplemousse xav.maso@gmail.com

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@Pamplemousse Pamplemousse requested review from FRidh and jonringer as code owners Sep 16, 2020
@FRidh FRidh self-assigned this Sep 16, 2020
@Pamplemousse Pamplemousse mentioned this pull request Sep 16, 2020
3 of 10 tasks complete
@FRidh
Copy link
Member

FRidh commented Sep 16, 2020

No, we do not allow multiple versions to be used within the package set.

@FRidh FRidh closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.