Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corefonts: fix hash mismatch update #98122

Merged
merged 1 commit into from Sep 19, 2020
Merged

Conversation

@turboMaCk
Copy link
Member

turboMaCk commented Sep 16, 2020

This fixes error:

fix hash missmatch
wanted: sha256:0baadsrgpqj15fgjmcn0aim0k0nk7mvivcxinw1zwg61kkcwhalx
got:    sha256:089d2m9bvaacj36qdq77pcazji0sbbr796shic3k52cpxkjnzbwh
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

danieldk left a comment

Good catch!

Result of nixpkgs-review pr 98122 1

1 package built:
  • corefonts

I wondered what changed the fixed-output. Turns out it was 6dd3b54.

@danieldk danieldk merged commit a9953f1 into NixOS:master Sep 19, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
corefonts, corefonts.passthru.tests on aarch64-linux No attempt
Details
corefonts, corefonts.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b529c6c"; rev="b529c6cf652860c3cda0c5e29d6233ea0d0a1e17"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b529c6c"; rev="b529c6cf652860c3cda0c5e29d6233ea0d0a1e17"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b529c6c"; rev="b529c6cf652860c3cda0c5e29d6233ea0d0a1e17"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b529c6c"; rev="b529c6cf652860c3cda0c5e29d6233ea0d0a1e17"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b529c6c"; rev="b529c6cf652860c3cda0c5e29d6233ea0d0a1e17"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b529c6c"; rev="b529c6cf652860c3cda0c5e29d6233ea0d0a1e17"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b529c6c"; rev="b529c6cf652860c3cda0c5e29d6233ea0d0a1e17"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@turboMaCk
Copy link
Member Author

turboMaCk commented Sep 19, 2020

btw @danieidk I'm not entirely sure but I think this might need to be backported to release. But I'm not completely sure about that.

@danieldk
Copy link
Member

danieldk commented Sep 19, 2020

btw @danieidk I'm not entirely sure but I think this might need to be backported to release. But I'm not completely sure about that.

Since it this is a fixed-output derivation and the Nix binary cache has never been garbage collected, this should continue to work. Though I think it's worth backporting, it's a bug and the backport is unlikely to break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.