Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests-aws4auth: unbreak on python 3.x, cleanup #98138

Closed
wants to merge 1 commit into from

Conversation

@maxeaubrey
Copy link
Contributor

@maxeaubrey maxeaubrey commented Sep 17, 2020

Motivation for this change

Entirely removed postPatch as that file no longer exists. Discovered this breakage when attempting to run the ELK test - post changes the test appears to finish fine, including elasticsearch-curator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
postPatch was attemptting to sed in a file that no longer exists
tests are still broken on python 3.x

additionally misc cleanup and corrected homepage to be current
@maxeaubrey maxeaubrey requested review from FRidh and jonringer as code owners Sep 17, 2020
@ofborg ofborg bot added the 6.topic: python label Sep 17, 2020
@maxeaubrey
Copy link
Contributor Author

@maxeaubrey maxeaubrey commented Sep 17, 2020

Result of nixpkgs-review pr 98138 1

4 packages built:
  • elasticsearch-curator
  • python27Packages.requests-aws4auth
  • python37Packages.requests-aws4auth
  • python38Packages.requests-aws4auth
Copy link
Member

@FRidh FRidh left a comment

Please don't make any unnecessary style changes.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 18, 2020

I think I merged a fix for this, sorry, I saw the other first

@maxeaubrey maxeaubrey closed this Sep 18, 2020
@maxeaubrey maxeaubrey deleted the maxeaubrey:maxine/unbreak_requests-aws4auth branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.