Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hime: init at unstable-2020-06-27 #98163

Merged
merged 2 commits into from Oct 4, 2020
Merged

hime: init at unstable-2020-06-27 #98163

merged 2 commits into from Oct 4, 2020

Conversation

@yanganto
Copy link
Contributor

@yanganto yanganto commented Sep 17, 2020

Motivation for this change

Add hime input method

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    Result: No diff detected, stopping review...
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ref: HIME team build script on Arch
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=hime-git

@yanganto yanganto changed the title hime: init hime: init at 2020-06-27 Sep 24, 2020
@yanganto yanganto changed the title hime: init at 2020-06-27 hime: init at unstable-2020-06-27 Sep 24, 2020
@yanganto yanganto force-pushed the yanganto:hime branch 3 times, most recently from fb15468 to 416923f Sep 24, 2020
@yanganto yanganto changed the title hime: init at unstable-2020-06-27 [WIP] hime: init at unstable-2020-06-27 Sep 24, 2020
@yanganto yanganto force-pushed the yanganto:hime branch 2 times, most recently from 5c75cef to f7e09f7 Sep 25, 2020
@yanganto yanganto force-pushed the yanganto:hime branch from f7e09f7 to 833718d Oct 3, 2020
@yanganto yanganto changed the title [WIP] hime: init at unstable-2020-06-27 hime: init at unstable-2020-06-27 Oct 3, 2020
@yanganto yanganto force-pushed the yanganto:hime branch from 833718d to 0c13879 Oct 3, 2020
@yanganto
Copy link
Contributor Author

@yanganto yanganto commented Oct 4, 2020

Hi @marsam, @worldofpeace,
Could you take a look at this PR? I am a new user of NixOS and want to use the input method which I used in Archlinux.
Many thanks.

@marsam
marsam approved these changes Oct 4, 2020
@marsam marsam merged commit e940c41 into NixOS:master Oct 4, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0c13879"; rev="0c138794af79ddc3907b6e3375edde5aaec08001"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0c13879"; rev="0c138794af79ddc3907b6e3375edde5aaec08001"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0c13879"; rev="0c138794af79ddc3907b6e3375edde5aaec08001"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0c13879"; rev="0c138794af79ddc3907b6e3375edde5aaec08001"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0c13879"; rev="0c138794af79ddc3907b6e3375edde5aaec08001"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0c13879"; rev="0c138794af79ddc3907b6e3375edde5aaec08001"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0c13879"; rev="0c138794af79ddc3907b6e3375edde5aaec08001"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@yanganto yanganto mentioned this pull request Oct 16, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.