Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.48.2 -> 1.49.1 #98189

Merged
merged 1 commit into from Sep 24, 2020
Merged

Conversation

@samuela
Copy link
Contributor

@samuela samuela commented Sep 18, 2020

Motivation for this change

Upgrades vscode from 1.48.2 to 1.49.1.

This PR was automatically generated by nixpkgs-upkeep. Internal tag: cd0d09d9c668c54e4ee93799d6921fff

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@eadwu
eadwu approved these changes Sep 18, 2020
Copy link
Member

@eadwu eadwu left a comment

Verified hashes.

Copy link
Member

@danieldk danieldk left a comment

Please set the change the commit message and PR title according to the contribution guidelines.

Also, I realize that this was generated automatically, but it really helps if PRs have a correctly filled PR template:

https://github.com/NixOS/nixpkgs/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@samuela samuela force-pushed the samuela:upkeep-bot/vscode-1.49.1-1600387697 branch from dd2aea9 to d34dafc Sep 19, 2020
@samuela samuela changed the title Update vscode to 1.49.1 vscode: 1.48.2 -> 1.49.1 Sep 19, 2020
@samuela
Copy link
Contributor Author

@samuela samuela commented Sep 19, 2020

@danieldk Ok, I've edited this PR, and I'll upgrade nixpkgs-upkeep to fix this in the future!

@ofborg ofborg bot requested a review from eadwu Sep 19, 2020
@austinbutler austinbutler mentioned this pull request Sep 21, 2020
1 of 10 tasks complete
@samuela
Copy link
Contributor Author

@samuela samuela commented Sep 23, 2020

friendly ping on this

Copy link
Member

@danieldk danieldk left a comment

Thanks! LGTM.

Result of nixpkgs-review pr 98189 1

2 packages built:
  • vscode
  • vscode-with-extensions

Runs as expected.

@danieldk danieldk merged commit fce6a30 into NixOS:master Sep 24, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
vscode, vscode.passthru.tests on aarch64-linux No attempt
Details
vscode, vscode.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d34dafc"; rev="d34dafcd2bc53287b2a9137e7ead3cde88f3290c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d34dafc"; rev="d34dafcd2bc53287b2a9137e7ead3cde88f3290c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d34dafc"; rev="d34dafcd2bc53287b2a9137e7ead3cde88f3290c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d34dafc"; rev="d34dafcd2bc53287b2a9137e7ead3cde88f3290c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d34dafc"; rev="d34dafcd2bc53287b2a9137e7ead3cde88f3290c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d34dafc"; rev="d34dafcd2bc53287b2a9137e7ead3cde88f3290c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d34dafc"; rev="d34dafcd2bc53287b2a9137e7ead3cde88f3290c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@samuela samuela deleted the samuela:upkeep-bot/vscode-1.49.1-1600387697 branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.