Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackage.binary-search: unbreak #98196

Closed
wants to merge 0 commits into from

Conversation

@LaloHao
Copy link

@LaloHao LaloHao commented Sep 18, 2020

Motivation for this change

Fix broken haskell package "binary-search"

Things done
  • Created patch

  • Removed broken flag

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

I will try and test with more of those parameters in the meantime

@@ -235,7 +235,7 @@ self: super: {
aws = dontCheck super.aws; # needs aws credentials
aws-kinesis = dontCheck super.aws-kinesis; # needs aws credentials for testing
binary-protocol = dontCheck super.binary-protocol; # http://hydra.cryp.to/build/499749/log/raw
binary-search = dontCheck super.binary-search;
binary-search = dontCheck (appendPatch super.binary-search ./patches/binary-search-1.0.0.3-ghc-8.8.patch);

This comment has been minimized.

@cdepillabout

cdepillabout Sep 18, 2020
Member

Is there anyway you can pull this patch from upstream? Normally we try to avoid carrying around patches here in nipxkgs if possible.

Check in this file for uses of fetchpatch to see how this can be done.

This comment has been minimized.

@peti

peti Nov 13, 2020
Member

Ping?

@@ -40405,7 +40405,6 @@ self: {
description = "Binary and exponential searches";
license = stdenv.lib.licenses.bsd3;
hydraPlatforms = stdenv.lib.platforms.none;
broken = true;

This comment has been minimized.

@cdepillabout

cdepillabout Sep 18, 2020
Member

This file shouldn't be edited directly, but instead the - binary-search line should be removed from the broken-packages section of pkgs/development/haskell-modules/configuration-hackage2nix.nix. Then binary-search will automatically be marked as non-broken the next time pkgs/development/haskell-modules/hackage-packages.nix is automatically regenerated.

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Sep 18, 2020

One last small thing. In general, you should try to format commit messages as described in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md. So for this PR, the commit might look like:

haskellPackage.binary-search: unbreak

(Or even something more descriptive.)

@peti peti force-pushed the NixOS:haskell-updates branch 2 times, most recently from 659ff55 to d0541e2 Sep 18, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 3 times, most recently from be2e4fb to 1436509 Oct 9, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 3 times, most recently from d060d81 to c90c206 Oct 23, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 3 times, most recently from 87295a3 to e240cce Oct 30, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 4 times, most recently from 82a05ac to 7d050d4 Nov 6, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 3 times, most recently from 0cf6d0c to c55cdb4 Nov 13, 2020
@LaloHao LaloHao changed the title FIX: Broken haskellPackage.binary-search for latest GHC version haskellPackage.binary-search: unbreak Nov 20, 2020
@LaloHao LaloHao closed this Nov 20, 2020
@LaloHao LaloHao force-pushed the LaloHao:haskell-updates branch from 96ed039 to 4f2880b Nov 20, 2020
@LaloHao
Copy link
Author

@LaloHao LaloHao commented Nov 20, 2020

Sorry, i wasn't active.
I have read the contributing guide now.

I am making another branch since this is becoming a mess, is that ok?

@LaloHao LaloHao mentioned this pull request Nov 20, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.