Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluej: init at 4.2.2 #98204

Merged
merged 2 commits into from Sep 21, 2020
Merged

bluej: init at 4.2.2 #98204

merged 2 commits into from Sep 21, 2020

Conversation

@charvp
Copy link
Contributor

@charvp charvp commented Sep 18, 2020

Motivation for this change

I need it for a university course I'm a teaching assistent for. Based on #59718 (and the review comments left there).

Things done

Running the program works (only with the jetbrains JDK, sadly, openjdk hangs on the boot splash). In the program, creating a new project, compiling a class, creating a new object and calling a method on that object works.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@charvp charvp force-pushed the charvp:pr/init-bluej branch 4 times, most recently from 9ddb904 to 459a72c Sep 20, 2020
pkgs/applications/editors/bluej/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/bluej/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/bluej/default.nix Outdated Show resolved Hide resolved
@charvp charvp force-pushed the charvp:pr/init-bluej branch from 459a72c to 9ee2a84 Sep 20, 2020
@charvp charvp force-pushed the charvp:pr/init-bluej branch from 9ee2a84 to be0243e Sep 21, 2020
@charvp charvp force-pushed the charvp:pr/init-bluej branch from be0243e to 2a1d3c1 Sep 21, 2020
@charvp charvp force-pushed the charvp:pr/init-bluej branch from 2a1d3c1 to 090cc5d Sep 21, 2020
Copy link
Contributor

@doronbehar doronbehar left a comment

Builds fine with nixpkgs-review and GUI seems functional.

@doronbehar doronbehar merged commit 20bd6dd into NixOS:master Sep 21, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
bluej, bluej.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
bluej, bluej.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="090cc5d"; rev="090cc5d6ea548221cd7ec61b10003a446cd9bca3"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="090cc5d"; rev="090cc5d6ea548221cd7ec61b10003a446cd9bca3"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="090cc5d"; rev="090cc5d6ea548221cd7ec61b10003a446cd9bca3"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="090cc5d"; rev="090cc5d6ea548221cd7ec61b10003a446cd9bca3"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="090cc5d"; rev="090cc5d6ea548221cd7ec61b10003a446cd9bca3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="090cc5d"; rev="090cc5d6ea548221cd7ec61b10003a446cd9bca3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="090cc5d"; rev="090cc5d6ea548221cd7ec61b10003a446cd9bca3"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@charvp charvp deleted the charvp:pr/init-bluej branch Sep 21, 2020
@charvp charvp mentioned this pull request Sep 27, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.