Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.logging-effect: fix dependency resolution #98205

Closed

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 18, 2020

Motivation for this change

This probably fixes another 10 packages that depend on this library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
logging-effect = markUnbroken (super.logging-effect.override {
unliftio-core = super.unliftio-core_0_2_0_1;
});
Comment on lines +1363 to +1365

This comment has been minimized.

@cdepillabout

cdepillabout Sep 18, 2020
Member

Is this for ZHF? If so, then it is basically fine as it is (assuming you will just commit straight to the release-20.09 branch).

If this isn't for ZHF, and you just want this fixed in master, can you do the following?

  1. Change the base branch on github to haskell-updates (and probably rebase on haskell-updates as well).

  2. Instead of using markUnbroken in this file, remove logging-effect from the broken-packages list in configuration-hackage2nix.nix.

    The hackage-packages.nix file gets regenerated daily on the haskell-updates branch. Since you've removed logging-effect from the list of broken packages, next time hackage-packages.nix is regenerated, it will be regenerated without the logging-effect package having broken = true;.

This comment has been minimized.

@zimbatm

zimbatm Sep 18, 2020
Author Member

Not directly but it will help with ZHF and can be backported to 20.09.

Now that I have played with the patch more, I think a better solution is to pin the version to logging-effect ==1.3.10 because otherwise, it will not work with those other libraries.

This comment has been minimized.

@peti

peti Nov 13, 2020
Member

Will there be more updates to this pull request?

@zimbatm
Copy link
Member Author

@zimbatm zimbatm commented Oct 30, 2020

The solution is actually to downgrade logging-effect to v1.3.10. Overriding unliftio-core is problematic because other packages might be using the newer version. But I don't know enough of the haskell ecosystem to fix that.

@zimbatm zimbatm closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.