Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercism: Add NobbZ as maintainer #98207

Merged
merged 2 commits into from Sep 18, 2020
Merged

Conversation

@NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Sep 18, 2020

Motivation for this change

The user @rbasso, who has been an active member in the exercism community a long time ago, and was the only maintainer of the exercism package has left GitHub as it seems. His profile is nearly empty and does not show a single GitHub contribution over the last year.

As I am still an active GitHub user, an active member of the exercism.io community and a nixOS user and provided last two version bumps of the package, I think it makes sense to set myself as package maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@NobbZ NobbZ changed the title Exercism maintainer exercism: Add NobbZ as maintainer Sep 18, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Thanks for taking over this package!

@cdepillabout cdepillabout merged commit 47ee595 into NixOS:master Sep 18, 2020
18 checks passed
18 checks passed
tests tests
Details
action
Details
exercism, exercism.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
exercism, exercism.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76e3103"; rev="76e3103b7ab863e2da8ebdb2e0496d1785d8c57b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76e3103"; rev="76e3103b7ab863e2da8ebdb2e0496d1785d8c57b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76e3103"; rev="76e3103b7ab863e2da8ebdb2e0496d1785d8c57b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76e3103"; rev="76e3103b7ab863e2da8ebdb2e0496d1785d8c57b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76e3103"; rev="76e3103b7ab863e2da8ebdb2e0496d1785d8c57b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76e3103"; rev="76e3103b7ab863e2da8ebdb2e0496d1785d8c57b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="76e3103"; rev="76e3103b7ab863e2da8ebdb2e0496d1785d8c57b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.