Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.cartopy: 0.17 -> 0.18 #98210

Merged
merged 1 commit into from Sep 18, 2020
Merged

python3.pkgs.cartopy: 0.17 -> 0.18 #98210

merged 1 commit into from Sep 18, 2020

Conversation

@povik
Copy link
Contributor

@povik povik commented Sep 18, 2020

Fixes build. Formerly cartopy tests were failing, likely since update of
matplotlib to 3.3.0.

I ran few usage examples (x86_64-linux) to verify the library is ok.

May fix build failure on darwin reported in #96864.
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes build. Formerly cartopy tests were failing, likely since update of
matplotlib to 3.3.0.
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98210 1

2 packages built:
  • python37Packages.cartopy
  • python38Packages.cartopy

@jonringer jonringer merged commit 2047252 into NixOS:master Sep 18, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="afc7d9f"; rev="afc7d9f2232d57fe0699963f5a35bade02f83863"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="afc7d9f"; rev="afc7d9f2232d57fe0699963f5a35bade02f83863"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="afc7d9f"; rev="afc7d9f2232d57fe0699963f5a35bade02f83863"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="afc7d9f"; rev="afc7d9f2232d57fe0699963f5a35bade02f83863"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="afc7d9f"; rev="afc7d9f2232d57fe0699963f5a35bade02f83863"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="afc7d9f"; rev="afc7d9f2232d57fe0699963f5a35bade02f83863"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="afc7d9f"; rev="afc7d9f2232d57fe0699963f5a35bade02f83863"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@povik povik mentioned this pull request Sep 18, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.