Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] perlPackages.DBI: 1.642 -> 1.643 (for CVE-2020-14392, CVE-2020-14393) #98219

Merged

Conversation

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 18, 2020

Motivation for this change

To address:

  • CVE-2020-14392: Memory corruption in XS functions when Perl stack is reallocated
  • CVE-2020-14393: Fixed a buffer overflow on an overlong DBD class name

https://metacpan.org/pod/distribution/DBI/Changes#Changes-in-DBI-1.643

https://www.suse.com/security/cve/CVE-2020-14392.html
https://www.suse.com/security/cve/CVE-2020-14393.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
…2020-14393)

(cherry picked from commit 12ebbef)
@volth
volth approved these changes Sep 18, 2020
Copy link
Contributor

@volth volth left a comment

did you mean 20.09 ?

@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Sep 18, 2020

did you mean 20.09 ?

20.09 is already on 1.643, 20.03 needs this fix.

@stigtsp stigtsp requested a review from worldofpeace Sep 22, 2020
@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Sep 25, 2020

Result of nixpkgs-review pr 98219 1

2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
3 packages failed to build:
  • kdeApplications.kdepim-addons
  • openxpki
  • unixODBCDrivers.mysql
134 packages built:
  • akonadi (kdeApplications.akonadi)
  • akregator (kdeApplications.akregator)
  • almanah
  • automysqlbackup
  • check-mssql-health
  • diesel-cli
  • digikam
  • gnome3.evolution
  • hydra-migration
  • hydra-unstable
  • kaddressbook (kdeApplications.kaddressbook)
  • kdeApplications.akonadi-calendar
  • kdeApplications.akonadi-contacts
  • kdeApplications.akonadi-import-wizard
  • kdeApplications.akonadi-mime
  • kdeApplications.akonadi-notes
  • kdeApplications.akonadi-search
  • kdeApplications.akonadiconsole
  • kdeApplications.calendarsupport
  • kdeApplications.eventviews
  • kdeApplications.incidenceeditor
  • kdeApplications.kalarm
  • kdeApplications.kalarmcal
  • kdeApplications.kdepim-apps-libs
  • kdeApplications.kdepim-runtime
  • kgpg (kdeApplications.kgpg)
  • kmail (kdeApplications.kmail)
  • kdeApplications.kmail-account-wizard
  • kdeApplications.kmailtransport
  • kdeApplications.knotes
  • kontact (kdeApplications.kontact)
  • korganizer (kdeApplications.korganizer)
  • kdeApplications.libgravatar
  • kdeApplications.libkdepim
  • kdeApplications.libksieve
  • kdeApplications.mailcommon
  • kdeApplications.mailimporter
  • kdeApplications.mbox-importer
  • kdeApplications.messagelib
  • kdeApplications.pim-data-exporter
  • kdeApplications.pim-sieve-editor
  • kdeApplications.pimcommon
  • kmymoney
  • longview
  • mysql (mariadb)
  • munin
  • ninka
  • nix-serve
  • perl528Packages.AppSqitch
  • perl528Packages.Autodia
  • perl528Packages.CatalystAuthenticationStoreDBIxClass
  • perl528Packages.CatalystModelDBICSchema
  • perl528Packages.CatalystViewCSV
  • perl528Packages.Connector
  • perl528Packages.DBDMock
  • perl528Packages.DBDOracle
  • perl528Packages.DBDPg
  • perl528Packages.DBDSQLite
  • perl528Packages.DBDmysql
  • perl528Packages.DBDsybase
  • perl528Packages.DBI
  • perl528Packages.DBICxTestDatabase
  • perl528Packages.DBIxClass
  • perl528Packages.DBIxClassCandy
  • perl528Packages.DBIxClassCursorCached
  • perl528Packages.DBIxClassDynamicDefault
  • perl528Packages.DBIxClassHTMLWidget
  • perl528Packages.DBIxClassHelpers
  • perl528Packages.DBIxClassInflateColumnSerializer
  • perl528Packages.DBIxClassIntrospectableM2M
  • perl528Packages.DBIxClassSchemaLoader
  • perl528Packages.DBIxConnector
  • perl528Packages.DBIxDBSchema
  • perl528Packages.DBIxIntrospector
  • perl528Packages.DBIxSearchBuilder
  • perl528Packages.DBIxSimple
  • perl528Packages.GoferTransporthttp
  • perl528Packages.MojoSQLite
  • perl528Packages.Mojomysql
  • perl528Packages.PerconaToolkit
  • perl528Packages.SQLAbstractLimit
  • perl528Packages.SQLTranslator
  • perl528Packages.TaskCatalystTutorial
  • perl528Packages.Workflow
  • perl528Packages.maatkit
  • perl530Packages.AppSqitch
  • perl530Packages.Autodia
  • perl530Packages.CatalystAuthenticationStoreDBIxClass
  • perl530Packages.CatalystModelDBICSchema
  • perl530Packages.CatalystViewCSV
  • perl530Packages.Connector
  • perl530Packages.DBDMock
  • perl530Packages.DBDOracle
  • perl530Packages.DBDPg
  • perl530Packages.DBDSQLite
  • perl530Packages.DBDmysql
  • perl530Packages.DBDsybase
  • perl530Packages.DBI
  • perl530Packages.DBICxTestDatabase
  • perl530Packages.DBIxClass
  • perl530Packages.DBIxClassCandy
  • perl530Packages.DBIxClassCursorCached
  • perl530Packages.DBIxClassDynamicDefault
  • perl530Packages.DBIxClassHTMLWidget
  • perl530Packages.DBIxClassHelpers
  • perl530Packages.DBIxClassInflateColumnSerializer
  • perl530Packages.DBIxClassIntrospectableM2M
  • perl530Packages.DBIxClassSchemaLoader
  • perl530Packages.DBIxConnector
  • perl530Packages.DBIxDBSchema
  • perl530Packages.DBIxIntrospector
  • perl530Packages.DBIxSearchBuilder
  • perl530Packages.DBIxSimple
  • perl530Packages.GoferTransporthttp
  • perl530Packages.MojoSQLite
  • perl530Packages.Mojomysql
  • perl530Packages.PerconaToolkit
  • perl530Packages.SQLAbstractLimit
  • perl530Packages.SQLTranslator
  • perl530Packages.TaskCatalystTutorial
  • perl530Packages.Workflow
  • perl530Packages.maatkit
  • popfile
  • public-inbox
  • rt
  • slimserver
  • snabb
  • spamassassin
  • sqitchPg
  • sympa
  • trojita
  • x2goserver
  • zanshin
  • zoneminder
@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Sep 25, 2020

3 packages failed to build:

Marked as broken:

kdeApplications.kdepim-addons
openxpki
unixODBCDrivers.mysql

@stigtsp stigtsp merged commit a0075f2 into NixOS:release-20.03 Sep 25, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b80326"; rev="2b803260a6e917a541a10cafee0f753ca5daf901"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b80326"; rev="2b803260a6e917a541a10cafee0f753ca5daf901"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b80326"; rev="2b803260a6e917a541a10cafee0f753ca5daf901"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b80326"; rev="2b803260a6e917a541a10cafee0f753ca5daf901"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b80326"; rev="2b803260a6e917a541a10cafee0f753ca5daf901"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b80326"; rev="2b803260a6e917a541a10cafee0f753ca5daf901"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b80326"; rev="2b803260a6e917a541a10cafee0f753ca5daf901"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.