Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Packages.requests-aws4auth: fix build #98221

Merged
merged 1 commit into from Sep 18, 2020

Conversation

@wkral
Copy link
Contributor

@wkral wkral commented Sep 18, 2020

(cherry picked from commit 5f0f2b8)

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit 5f0f2b8)
@wkral wkral requested review from FRidh and jonringer as code owners Sep 18, 2020
@wkral
Copy link
Contributor Author

@wkral wkral commented Sep 18, 2020

Result of nixpkgs-review pr 98221 1

4 packages built:
  • elasticsearch-curator
  • python27Packages.requests-aws4auth
  • python37Packages.requests-aws4auth
  • python38Packages.requests-aws4auth
@ofborg ofborg bot added the 6.topic: python label Sep 18, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98221 1

4 packages built:
  • elasticsearch-curator
  • python27Packages.requests-aws4auth
  • python37Packages.requests-aws4auth
  • python38Packages.requests-aws4auth

@jonringer jonringer merged commit 344d782 into NixOS:release-20.09 Sep 18, 2020
1 of 3 checks passed
1 of 3 checks passed
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval Checking new out paths
Details
@ofborg ofborg bot requested a review from basvandijk Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.