Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Packages.word2vec: fix build and tests #98223

Merged
merged 1 commit into from Sep 22, 2020

Conversation

@wkral
Copy link
Contributor

@wkral wkral commented Sep 18, 2020

(cherry picked from commit 6a4e785)

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit 6a4e785)
@wkral wkral requested review from FRidh and jonringer as code owners Sep 18, 2020
@wkral
Copy link
Contributor Author

@wkral wkral commented Sep 18, 2020

Result of nixpkgs-review pr 98223 1

2 packages built:
  • python37Packages.word2vec
  • python38Packages.word2vec
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98223 1

2 packages built:
  • python37Packages.word2vec
  • python38Packages.word2vec

@wkral
Copy link
Contributor Author

@wkral wkral commented Sep 22, 2020

@jonringer noticed that this hasn't been merged, guessing just overlooked amongst the many PRs. If it does need work please let me know.

@jonringer jonringer merged commit 4eec4a7 into NixOS:release-20.09 Sep 22, 2020
16 checks passed
16 checks passed
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b10818a"; rev="b10818ac6cfd6c34aaa298d0621cce77cb81dd76"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b10818a"; rev="b10818ac6cfd6c34aaa298d0621cce77cb81dd76"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b10818a"; rev="b10818ac6cfd6c34aaa298d0621cce77cb81dd76"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b10818a"; rev="b10818ac6cfd6c34aaa298d0621cce77cb81dd76"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b10818a"; rev="b10818ac6cfd6c34aaa298d0621cce77cb81dd76"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b10818a"; rev="b10818ac6cfd6c34aaa298d0621cce77cb81dd76"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b10818a"; rev="b10818ac6cfd6c34aaa298d0621cce77cb81dd76"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 22, 2020

i do a rebase, github probably had a merge right before this, and it failed to apply

@wkral wkral deleted the wkral:backport-py-word2vec branch Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.