Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ROCm 3.8.0 #98230

Merged
merged 9 commits into from Sep 23, 2020
Merged

Update to ROCm 3.8.0 #98230

merged 9 commits into from Sep 23, 2020

Conversation

@danieldk
Copy link
Member

@danieldk danieldk commented Sep 18, 2020

Motivation for this change

Update to ROCm 3.8.0.

cc: @acowley @Flakebi

It would be nice if someone could test if this works, I had to replace my RX380.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
danieldk added 6 commits Sep 19, 2020
The tag refers to the same commit as 3.7.0, so the hash did not
change.
The tag refers to the same commit as 3.7.0, so the hash did not
change.
The tag refers to the same commit as 3.7.0, so the hash did not
change.
@danieldk danieldk force-pushed the danieldk:rocm-3.8.0 branch from 860a5ef to 57bf669 Sep 19, 2020
@danieldk danieldk marked this pull request as ready for review Sep 19, 2020
@danieldk danieldk requested a review from matthewbauer as a code owner Sep 19, 2020
@danieldk danieldk removed the request for review from matthewbauer Sep 19, 2020
@Flakebi
Copy link
Member

@Flakebi Flakebi commented Sep 23, 2020

Thanks, seems to build and work fine. clinfo works, other OpenCL samples hang my (unsupported) GPU, so same as 3.7 for me.

$ nixpkgs-review pr 98230
9 packages built:
rocclr rocm-cmake rocm-comgr rocm-device-libs rocm-opencl-icd rocm-opencl-runtime rocm-runtime rocm-smi rocm-thunk
@danieldk
Copy link
Member Author

@danieldk danieldk commented Sep 23, 2020

Thanks for testing. Hopefully there will soon be progress on Navi.

@danieldk danieldk merged commit 66d0662 into NixOS:master Sep 23, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
rocclr, rocclr.passthru.tests, rocm-cmake, rocm-cmake.passthru.tests, rocm-comgr, rocm-comgr.passthru.tests, rocm-device-libs, rocm-device-libs.passthru.tests, rocm-opencl-runtime, rocm-opencl-runtime.passthru.tests, rocm-runtime, rocm-runtime.passthru.tests, rocm-smi, rocm-smi.passthru.tests, rocm-thunk, rocm-thunk.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="57bf669"; rev="57bf6699c1830b8511c3b27a1d2db8f058916b9e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="57bf669"; rev="57bf6699c1830b8511c3b27a1d2db8f058916b9e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="57bf669"; rev="57bf6699c1830b8511c3b27a1d2db8f058916b9e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="57bf669"; rev="57bf6699c1830b8511c3b27a1d2db8f058916b9e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="57bf669"; rev="57bf6699c1830b8511c3b27a1d2db8f058916b9e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="57bf669"; rev="57bf6699c1830b8511c3b27a1d2db8f058916b9e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="57bf669"; rev="57bf6699c1830b8511c3b27a1d2db8f058916b9e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rocclr, rocclr.passthru.tests, rocm-cmake, rocm-cmake.passthru.tests, rocm-comgr, rocm-comgr.passthru.tests, rocm-device-libs, rocm-device-libs.passthru.tests, rocm-opencl-runtime, rocm-opencl-runtime.passthru.tests, rocm-runtime, rocm-runtime.passthru.tests, rocm-smi, rocm-smi.passthru.tests, rocm-thunk, rocm-thunk.passthru.tests on x86_64-linux Success
Details
@danieldk danieldk deleted the danieldk:rocm-3.8.0 branch Sep 23, 2020
@acowley
Copy link
Contributor

@acowley acowley commented Sep 23, 2020

Sorry for the delay, I started building 3.8 things this morning, but it's not done yet. The changes all look innocuous, but I'll report back in any case.

@acowley
Copy link
Contributor

@acowley acowley commented Sep 23, 2020

OpenCL and HIP are working for me with these updates, thank you @danieldk!

@danieldk
Copy link
Member Author

@danieldk danieldk commented Sep 24, 2020

Awesome, thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.